diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-12-09 13:51:57 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2020-12-09 13:51:57 -0500 |
| commit | 1f8d2881175920d389078852bb1ff0799d744599 (patch) | |
| tree | 983b6e53db1f95649e8f90c94fe01f7f15b4c443 /gdb/valops.c | |
| parent | 6244c1196a49a5732ac3667b4df0f157cf681d7b (diff) | |
| download | binutils-1f8d2881175920d389078852bb1ff0799d744599.zip binutils-1f8d2881175920d389078852bb1ff0799d744599.tar.gz binutils-1f8d2881175920d389078852bb1ff0799d744599.tar.bz2 | |
gdb: make get_discrete_bounds return bool
get_discrete_bounds currently has three possible return values (see its
current doc for details). It appears that for all callers, it would be
sufficient to have a boolean "worked" / "didn't work" return value.
Change the return type of get_discrete_bounds to bool and adjust all
callers. Doing so simplifies the following patch.
gdb/ChangeLog:
* gdbtypes.h (get_discrete_bounds): Return bool, adjust all
callers.
* gdbtypes.c (get_discrete_bounds): Return bool.
Change-Id: Ie51feee23c75f0cd7939742604282d745db59172
Diffstat (limited to 'gdb/valops.c')
| -rw-r--r-- | gdb/valops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/valops.c b/gdb/valops.c index 4d0e002..09e97d2 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -453,7 +453,7 @@ value_cast (struct type *type, struct value *arg2) int val_length = TYPE_LENGTH (type2); LONGEST low_bound, high_bound, new_length; - if (get_discrete_bounds (range_type, &low_bound, &high_bound) < 0) + if (!get_discrete_bounds (range_type, &low_bound, &high_bound)) low_bound = 0, high_bound = 0; new_length = val_length / element_length; if (val_length % element_length != 0) @@ -3948,7 +3948,7 @@ value_slice (struct value *array, int lowbound, int length) error (_("array not associated")); range_type = array_type->index_type (); - if (get_discrete_bounds (range_type, &lowerbound, &upperbound) < 0) + if (!get_discrete_bounds (range_type, &lowerbound, &upperbound)) error (_("slice from bad array or bitstring")); if (lowbound < lowerbound || length < 0 |