diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-12-10 11:19:23 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-12-12 12:36:57 -0700 |
| commit | d61df89700bcf1633ca9db0ea403c2108c3cac3e (patch) | |
| tree | e9a230f46ba6995eb090ae026af1c6e46cf8ab97 /gdb/utils.h | |
| parent | db3ad2f031d4da70db35977abbcede0399d81d6b (diff) | |
| download | binutils-d61df89700bcf1633ca9db0ea403c2108c3cac3e.zip binutils-d61df89700bcf1633ca9db0ea403c2108c3cac3e.tar.gz binutils-d61df89700bcf1633ca9db0ea403c2108c3cac3e.tar.bz2 | |
Remove some calls to malloc_failure
I noticed a couple of spots that call malloc_failure, but that don't
need to.
* In xml-support.c, "concat" uses xmalloc, so cannot return NULL.
* In utils.c, "buildargv" also uses xmalloc, so can only return NULL
if the argument is empty.
Tested by the buildbot.
gdb/ChangeLog
2019-12-12 Tom Tromey <tromey@adacore.com>
* xml-support.c (xml_fetch_content_from_file): Don't call
malloc_failure.
* utils.h (class gdb_argv): Remove malloc_failure comment.
* utils.c (gdb_argv::reset): Don't call malloc_failure.
Change-Id: I59483620deb6609ccf2f024d94a29113bb62d1a9
Diffstat (limited to 'gdb/utils.h')
| -rw-r--r-- | gdb/utils.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/gdb/utils.h b/gdb/utils.h index c8337f2..7186019 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -146,10 +146,7 @@ public: } /* A constructor that calls buildargv on STR. STR may be NULL, in - which case this object is initialized with a NULL array. If - buildargv fails due to out-of-memory, call malloc_failure. - Therefore, the value is guaranteed to be non-NULL, unless the - parameter itself is NULL. */ + which case this object is initialized with a NULL array. */ explicit gdb_argv (const char *str) : m_argv (NULL) |