diff options
| author | Yao Qi <yao@codesourcery.com> | 2014-12-28 16:12:53 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2015-01-08 21:04:00 +0800 |
| commit | b597c318b86b5ad2bca1f72ee8c0fbe33cbb7dad (patch) | |
| tree | 2f53c515cafd11d64b9ec32de0d7e7d0dfa7bb3a /gdb/utils.h | |
| parent | 3565cf8fedf2bae2b383fae66dde62c3bdae51c9 (diff) | |
| download | binutils-b597c318b86b5ad2bca1f72ee8c0fbe33cbb7dad.zip binutils-b597c318b86b5ad2bca1f72ee8c0fbe33cbb7dad.tar.gz binutils-b597c318b86b5ad2bca1f72ee8c0fbe33cbb7dad.tar.bz2 | |
always read synthetic pointers as signed integers
I see the error message "access outside bounds of object referenced
via synthetic pointer" in the two fails below of mips gdb testing
print d[-2]^M
access outside bounds of object referenced via synthetic pointer^M
(gdb) FAIL: gdb.dwarf2/implptrconst.exp: print d[-2]
(gdb) print/d p[-1]^M
access outside bounds of object referenced via synthetic pointer^M
(gdb) FAIL: gdb.dwarf2/implptrpiece.exp: print/d p[-1]
in the first test, 'd[-2]' is processed by GDB as '* (&d[-2])'. 'd'
is a synthetic pointer, so its value is zero, the address of 'd[-2]'
is -2. In dwarf2loc.c:indirect_pieced_value,
/* This is an offset requested by GDB, such as value subscripts.
However, due to how synthetic pointers are implemented, this is
always presented to us as a pointer type. This means we have to
sign-extend it manually as appropriate. */
byte_offset = value_as_address (value);
if (TYPE_LENGTH (value_type (value)) < sizeof (LONGEST))
byte_offset = gdb_sign_extend (byte_offset,
8 * TYPE_LENGTH (value_type (value)));
byte_offset += piece->v.ptr.offset;
We know that the value is really an offset instead of address, so the
fix is to extract the value as an (signed) offset.
gdb:
2015-01-08 Pedro Alves <palves@redhat.com>
Yao Qi <yao@codesourcery.com>
* dwarf2loc.c (indirect_pieced_value): Don't call
gdb_sign_extend. Call extract_signed_integer instead.
* utils.c (gdb_sign_extend): Remove.
* utils.h (gdb_sign_extend): Remove declaration.
Diffstat (limited to 'gdb/utils.h')
| -rw-r--r-- | gdb/utils.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/gdb/utils.h b/gdb/utils.h index 0a73864..3debde7 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -340,11 +340,6 @@ extern int myread (int, char *, int); extern ULONGEST align_up (ULONGEST v, int n); extern ULONGEST align_down (ULONGEST v, int n); -/* Sign extend VALUE. BIT is the (1-based) index of the bit in VALUE - to sign-extend. */ - -extern LONGEST gdb_sign_extend (LONGEST value, int bit); - /* Resource limits used by getrlimit and setrlimit. */ enum resource_limit_kind |