diff options
| author | Tom Tromey <tom@tromey.com> | 2019-11-12 17:26:50 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-12-20 09:15:52 -0700 |
| commit | 61c33f105c71d27386e5b3cc6e1c5f71efe7ed01 (patch) | |
| tree | 3d61884a4c61df3cb404f931731d617fc4fe6060 /gdb/tui/tui-winsource.h | |
| parent | 469b073133fa35b54ab4f1bc3dee42ccede84689 (diff) | |
| download | binutils-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.zip binutils-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.tar.gz binutils-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.tar.bz2 | |
Change tui_source_window_base::set_contents to return bool
This changes tui_source_window_base::set_contents to return bool,
rather than tui_status. It also changes one implementation of
set_contents to use early returns rather than a variable, which IMO
makes it easier to follow.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
<set_contents>: Return bool.
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Update.
* tui/tui-source.h (struct tui_source_window) <set_contents>:
Return bool.
* tui/tui-source.c (tui_source_window::set_contents): Return
bool. Simplify.
* tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
Return bool.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Return
bool.
Change-Id: I8c5212400cd7aadf35760c22d5344cd3b9435674
Diffstat (limited to 'gdb/tui/tui-winsource.h')
| -rw-r--r-- | gdb/tui/tui-winsource.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 1ba967c..1991d04 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -87,10 +87,9 @@ protected: void rerender () override; - virtual enum tui_status set_contents - (struct gdbarch *gdbarch, - struct symtab *s, - struct tui_line_or_address line_or_addr) = 0; + virtual bool set_contents (struct gdbarch *gdbarch, + struct symtab *s, + struct tui_line_or_address line_or_addr) = 0; public: |