aboutsummaryrefslogtreecommitdiff
path: root/gdb/tui/tui-winsource.h
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-07-12 18:18:10 -0600
committerTom Tromey <tom@tromey.com>2019-08-16 14:17:36 -0600
commit398fdd6086a290748afcce0efabaebb4e363278c (patch)
treea661b12700f45fc6e8bf573ecffc91c10740f454 /gdb/tui/tui-winsource.h
parente699d33164a59dcfe7ad4a5154e5c6c811c1f958 (diff)
downloadbinutils-398fdd6086a290748afcce0efabaebb4e363278c.zip
binutils-398fdd6086a290748afcce0efabaebb4e363278c.tar.gz
binutils-398fdd6086a290748afcce0efabaebb4e363278c.tar.bz2
Remove the TUI execution info window
The TUI execution info window is unusual in that it is always linked to a source or disassembly window. Even updates of its content are handled by the source window, so it really has no life of its own. This patch removes this window entirely and puts its functionality directly into the source window. This simplifies the code somewhat. This is a user-visible change, because now the box around the source (or disassembly) window encloses the execution info as well. I consider this an improvement as well, though. Note that this patch caused ncurses to start emitting the "CSI Z" sequence, so I've added this to the test suite terminal implementation. gdb/ChangeLog 2019-08-16 Tom Tromey <tom@tromey.com> * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove. * tui/tui-winsource.h (struct tui_exec_info_window): Remove. (struct tui_source_window_base) <make_visible, refresh_window, resize>: Remove methods. <execution_info>: Remove field. * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content) (tui_show_source_line, tui_source_window_base) (~tui_source_window_base): Update. (tui_source_window_base::resize) (tui_source_window_base::make_visible) (tui_source_window_base::refresh_window): Remove. (tui_source_window_base::update_exec_info): Update. * tui/tui-source.c (tui_source_window::set_contents): Update. * tui/tui-disasm.c (tui_disasm_window::set_contents): Update. gdb/testsuite/ChangeLog 2019-08-16 Tom Tromey <tom@tromey.com> * lib/tuiterm.exp (_csi_Z): New proc. * gdb.tui/basic.exp: Update window positions. * gdb.tui/empty.exp: Update window positions.
Diffstat (limited to 'gdb/tui/tui-winsource.h')
-rw-r--r--gdb/tui/tui-winsource.h17
1 files changed, 0 insertions, 17 deletions
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 85e8302..1804ca7 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -45,16 +45,6 @@ DEF_ENUM_FLAGS_TYPE (enum tui_bp_flag, tui_bp_flags);
typedef char tui_exec_info_content[TUI_EXECINFO_SIZE];
-/* Execution info window class. */
-
-struct tui_exec_info_window : public tui_gen_win_info
-{
- tui_exec_info_window ()
- : tui_gen_win_info (EXEC_INFO_WIN)
- {
- }
-};
-
/* Elements in the Source/Disassembly Window. */
struct tui_source_element
{
@@ -113,8 +103,6 @@ public:
void clear_detail ();
- void make_visible (bool visible) override;
- void refresh_window () override;
void refresh_all () override;
/* Refill the source window's source cache and update it. If this
@@ -128,9 +116,6 @@ public:
virtual bool location_matches_p (struct bp_location *loc, int line_no) = 0;
- void resize (int height, int width,
- int origin_x, int origin_y) override;
-
void show_source_content ();
void update_exec_info ();
@@ -158,8 +143,6 @@ public:
/* Erase the source content. */
virtual void erase_source_content () = 0;
- /* Execution information window. */
- struct tui_exec_info_window *execution_info;
/* Used for horizontal scroll. */
int horizontal_offset = 0;
struct tui_line_or_address start_line_or_addr;