diff options
| author | Tom de Vries <tdevries@suse.de> | 2022-09-07 09:59:12 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2022-09-07 09:59:12 +0200 |
| commit | 6d0aebbcff0636fb11fb26116ef7ae53ecca314f (patch) | |
| tree | e124b2dadad119fef30628afc8ff18e4ccd279e9 /gdb/testsuite/gdb.threads | |
| parent | f555b327d41ed72ffae28caae550f5f86312db43 (diff) | |
| download | binutils-6d0aebbcff0636fb11fb26116ef7ae53ecca314f.zip binutils-6d0aebbcff0636fb11fb26116ef7ae53ecca314f.tar.gz binutils-6d0aebbcff0636fb11fb26116ef7ae53ecca314f.tar.bz2 | |
[gdb/testsuite] Use prototype to call libc functions
On openSUSE Tumbleweed (using glibc 2.36), I run into:
...
(gdb) print /d (int) munmap (4198400, 4096)^M
Invalid cast.^M
(gdb) FAIL: gdb.base/break-main-file-remove-fail.exp: cmdline: \
get integer valueof "(int) munmap (4198400, 4096)"
...
The problem is that after starting the executable, the symbol has type
"void (*) (void)":
...
(gdb) p munmap
$1 = {<text variable, no debug info>} 0x401030 <munmap@plt>
(gdb) start
...
(gdb) p munmap
$2 = {void (void)} 0x7ffff7feb9a0 <__GI_munmap>
...
which causes the "Invalid cast" error.
Looking at the debug info for glibc for symbol __GI_munmap:
...
<0><189683>: Abbrev Number: 1 (DW_TAG_compile_unit)
<189691> DW_AT_name : ../sysdeps/unix/syscall-template.S
<189699> DW_AT_producer : GNU AS 2.39.0
<1><1896ae>: Abbrev Number: 2 (DW_TAG_subprogram)
<1896af> DW_AT_name : __GI___munmap
<1896b3> DW_AT_external : 1
<1896b4> DW_AT_low_pc : 0x10cad0
<1896bc> DW_AT_high_pc : 37
...
that's probably caused by this bit (or similar bits for other munmap aliases).
This is fixed in gas on trunk by commit 5578fbf672e ("GAS: Add a return type
tag to DWARF DIEs generated for function symbols").
Work around this (for say gas 2.39) by explicitly specifying the prototype for
munmap.
Likewise for getpid in a couple of other test-cases.
Tested on x86_64-linux.
Diffstat (limited to 'gdb/testsuite/gdb.threads')
| -rw-r--r-- | gdb/testsuite/gdb.threads/siginfo-threads.exp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.threads/siginfo-threads.exp b/gdb/testsuite/gdb.threads/siginfo-threads.exp index f10c7fd..8dd34b7 100644 --- a/gdb/testsuite/gdb.threads/siginfo-threads.exp +++ b/gdb/testsuite/gdb.threads/siginfo-threads.exp @@ -41,7 +41,7 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"] set test "get pid" set pid "" -gdb_test_multiple "p (int) getpid ()" $test { +gdb_test_multiple "p ((int (*) (void))getpid) ()" $test { -re " = (\[0-9\]+)\r\n$gdb_prompt $" { set pid $expect_out(1,string) pass $test |