diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2022-01-17 11:27:36 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2022-03-31 13:07:21 -0400 |
commit | 5a0c4a06eb4f4afcf885596ee97706c1045a8476 (patch) | |
tree | 2a857ad7b52063ac2f056ae1de7ddeea0f8018e8 /gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c | |
parent | 20471e00e2ea400c5a7126a98fb58c6a83b50628 (diff) | |
download | binutils-5a0c4a06eb4f4afcf885596ee97706c1045a8476.zip binutils-5a0c4a06eb4f4afcf885596ee97706c1045a8476.tar.gz binutils-5a0c4a06eb4f4afcf885596ee97706c1045a8476.tar.bz2 |
gdb/linux-nat: remove check based on current_inferior in linux_handle_extended_wait
The check removed by this patch, using current_inferior, looks wrong.
When debugging multiple inferiors with the Linux native target and
linux_handle_extended_wait is called, there's no guarantee about which
is the current inferior. The vfork-done event we receive could be for
any inferior. If the vfork-done event is for a non-current inferior, we
end up wrongfully ignoring it. As a result, the core never processes a
TARGET_WAITKIND_VFORK_DONE event, program_space::breakpoints_not_allowed
is never cleared, and breakpoints are never reinserted. However,
because the Linux native target decided to ignore the event, it resumed
the thread - while breakpoints out. And that's bad.
The proposed fix is to remove this check. Always report vfork-done
events and let infrun's logic decide if it should be ignored. We don't
save much cycles by filtering the event here.
Add a test that replicates the situation described above. See comments
in the test for more details.
Change-Id: Ibe33c1716c3602e847be6c2093120696f2286fbf
Diffstat (limited to 'gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c')
-rw-r--r-- | gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c b/gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c new file mode 100644 index 0000000..a26ae07 --- /dev/null +++ b/gdb/testsuite/gdb.threads/vfork-multi-inferior-sleep.c @@ -0,0 +1,25 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <unistd.h> + +int +main (void) +{ + sleep (30); + return 0; +} |