diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2023-02-18 20:52:40 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2023-02-28 10:56:28 +0000 |
| commit | 47171eeb9468fd38e3785b0181d63a2abea3bf29 (patch) | |
| tree | 2b93b46f275ffcdecd531909e34c5a4e4b7e9208 /gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp | |
| parent | 292deeba7d6e0f1df99fff8c18000a1a3c481f3a (diff) | |
| download | binutils-47171eeb9468fd38e3785b0181d63a2abea3bf29.zip binutils-47171eeb9468fd38e3785b0181d63a2abea3bf29.tar.gz binutils-47171eeb9468fd38e3785b0181d63a2abea3bf29.tar.bz2 | |
gdb/testsuite: introduce is_target_non_stop helper proc
I noticed that several tests included copy & pasted code to run the
'maint show target-non-stop' command, and then switch based on the
result.
In this commit I factor this code out into a helper proc in
lib/gdb.exp, and update all the places I could find that used this
pattern to make use of the helper proc.
There should be no change in what is tested after this commit.
Reviewed-By: Pedro Alves <pedro@palves.net>
Diffstat (limited to 'gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp')
| -rw-r--r-- | gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp b/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp index 09b0548..2d3ace4 100644 --- a/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp +++ b/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp @@ -65,13 +65,9 @@ proc test { non_stop } { && ([target_info gdb_protocol] == "remote" || [target_info gdb_protocol] == "extended-remote")} { - gdb_test_multiple "maint show target-non-stop" "" { - -wrap -re "(is|currently) on.*" { - } - -wrap -re "(is|currently) off.*" { - unsupported "can't issue commands while target is running" - return 0 - } + if {![is_target_non_stop]} { + unsupported "can't issue commands while target is running" + return 0 } } |