diff options
author | Andrew Burgess <aburgess@redhat.com> | 2023-03-30 13:26:13 +0100 |
---|---|---|
committer | Andrew Burgess <aburgess@redhat.com> | 2023-04-27 13:56:36 +0100 |
commit | c5a5f322a4e50fbfb303874671ab541757a941cf (patch) | |
tree | 113cd87a1774c80768da195d971063625417f7fe /gdb/testsuite/gdb.stabs | |
parent | 131287d950a8cbd6e60eba2a9397a94a6d1a8697 (diff) | |
download | binutils-c5a5f322a4e50fbfb303874671ab541757a941cf.zip binutils-c5a5f322a4e50fbfb303874671ab541757a941cf.tar.gz binutils-c5a5f322a4e50fbfb303874671ab541757a941cf.tar.bz2 |
gdb/testsuite: use 'return' in gdb_test_no_output
A TCL proc will return the return value of the last command executed
within the proc's body if there is no explicit return call, so
gdb_test_no_output is already returning the return value of
gdb_test_multiple.
However, I'm not a fan of (relying on) this implicit return value
behaviour -- I prefer to be explicit about what we are doing. So in
this commit I have extended the comment on gdb_test_no_output to
document the possible return values (just as gdb_test does), and
explicitly call return.
This should make no different to our testing, but I think it's clearer
now what the gdb_test_no_output proc is expected to do.
The two tests gdb.base/auxv.exp and gdb.base/list.exp both rely on the
return value of gdb_test_no_output, and continue to pass after this
change.
I also spotted that gdb.base/watchpoint.exp could be updated to make
use of gdb_test_no_output, so I did that.
Reviewed-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/testsuite/gdb.stabs')
0 files changed, 0 insertions, 0 deletions