[gdb/cli] Add "set logging enabled", deprecate "set logging on/off"

Before commit 3b6acaee895 "Update more calls to add_prefix_cmd" we had the
following output for "show logging file":
...
$ gdb -q -batch -ex "set trace-commands on" \
    -ex "set logging off" \
    -ex "show logging file" \
    -ex "set logging on" \
    -ex "show logging file"
+set logging off
+show logging file
Future logs will be written to gdb.txt.
+set logging on
+show logging file
Currently logging to "gdb.txt".
...

After that commit we have instead:
...
+set logging off
+show logging file
The current logfile is "gdb.txt".
+set logging on
+show logging file
The current logfile is "gdb.txt".
...

Before the commit, whether logging is enabled or not can be deduced from the
output of the command.  After the commit, the message is unified and it's no
longer clear whether logging is enabled or not.

Fix this by:
- adding a new command "show logging enabled"
- adding a corresponding new command "set logging enabled on/off"
- making the commands "set logging on/off" deprecated aliases of the
  "set logging enabled on/off" command.

Update the docs and testsuite to use "set logging enabled".  Mention the new
and deprecated commands in NEWS.

Tested on x86_64-linux.

1 files changed, 6 insertions, 6 deletions

diff --git a/gdb/testsuite/gdb.mi/mi-logging.exp b/gdb/testsuite/gdb.mi/mi-logging.exp
index 35b9596..8672bcb 100644
--- a/gdb/testsuite/gdb.mi/mi-logging.exp
+++ b/gdb/testsuite/gdb.mi/mi-logging.exp
@@ -37,13 +37,13 @@ mi_gdb_test "-gdb-set logging file $milogfile" "\\^done" \
 
 mi_gdb_test "-gdb-set logging overwrite on" ".*"
 
-mi_gdb_test "-gdb-set logging on" ".*" "logging on"
+mi_gdb_test "-gdb-set logging enabled on" ".*" "logging on"
 
 mi_step "logged step"
 
 mi_next "logged next"
 
-mi_gdb_test "-gdb-set logging off" ".*" "logging off"
+mi_gdb_test "-gdb-set logging enabled off" ".*" "logging off"
 
 set chan [open $milogfile]
 set logcontent [read $chan]
@@ -64,11 +64,11 @@ mi_gdb_test "-gdb-set logging redirect on" ".*" "redirect logging on"
 # Since all output will be going into the file, just keep sending commands
 # and don't expect anything to appear until logging is turned off.
 
-send_gdb "1001-gdb-set logging on\n"
+send_gdb "1001-gdb-set logging enabled on\n"
 send_gdb "1002-exec-step\n"
 send_gdb "1003-exec-next\n"
 
-mi_gdb_test "1004-gdb-set logging off" ".*" "redirect logging off"
+mi_gdb_test "1004-gdb-set logging enabled off" ".*" "redirect logging off"
 
 set chan [open $milogfile]
 set logcontent [read $chan]
@@ -85,12 +85,12 @@ if [regexp "1001\\^done\[\r\n\]+$mi_log_prompt.*1002\\^running\[\r\n\]+\\*runnin
 with_test_prefix "redirect while already logging" {
     mi_gdb_test "-gdb-set logging redirect off" ".*" \
 	"logging redirect off"
-    mi_gdb_test "-gdb-set logging on" ".*" \
+    mi_gdb_test "-gdb-set logging enabled on" ".*" \
 	"logging on"
     mi_gdb_test "-gdb-set logging redirect on" \
 	".*warning: Currently logging .*Turn the logging off and on to make the new setting effective.*" \
 	"logging redirect on"
-    mi_gdb_test "-gdb-set logging off" ".*" \
+    mi_gdb_test "-gdb-set logging enabled off" ".*" \
 	"logging off"
 }