diff options
author | Lancelot SIX <lancelot.six@amd.com> | 2022-03-22 10:02:54 -0400 |
---|---|---|
committer | Lancelot SIX <lancelot.six@amd.com> | 2022-04-19 09:12:42 +0100 |
commit | 531c82a1c724079f98a4b069584681bc66da4dae (patch) | |
tree | b6c5c75bac8fa56639c689ac3eeed1cf180cc994 /gdb/testsuite/gdb.gdb | |
parent | 9a0f7f634e8eb98a8b2ff48eb68f90fefed83ac1 (diff) | |
download | binutils-531c82a1c724079f98a4b069584681bc66da4dae.zip binutils-531c82a1c724079f98a4b069584681bc66da4dae.tar.gz binutils-531c82a1c724079f98a4b069584681bc66da4dae.tar.bz2 |
gdb/selftest-arch: Make register_test_foreach_arch generate arch tests lazily
The register_test_foreach_arch is used to instantiate a given selftest
for all architectures supported by GDB. It is used in many _initialize_*
functions (under initialize_all_files, called by gdb_init).
Because the call is done during GDB's initialization, and because there
is no guaranty about the order in which all the _initialize_* functions
are executed, when register_test_foreach_arch is called, GDB is not
fully initialized. Specifically, when a particular initialize function
is executed, only the architectures registered at that point are listed
by gdbarch_printable_names.
As a consequence, the list of selftest effectively executed depends on
the order the _initialize_* functions are called. This can be observed
with the following:
$ ./gdb/gdb \
-data-directory ./gdb/data-directory \
-quiet -batch -ex "maint selftest" 2>&1 \
| grep -E "Ran [0-9]+ unit tests"
Ran 145 unit tests, 0 failed
$ GDB_REVERSE_INIT_FUNCTIONS=1 ./gdb/gdb \
-data-directory ./gdb/data-directory \
-quiet -batch -ex "maint selftest" 2>&1 \
| grep -E "Ran [0-9]+ unit tests"
Ran 82 unit tests, 0 failed
To fix this, make register_test_foreach_arch register a lazy selftest
generator. This way when the test generator is eventually executed, all
architectures are registered and we do not have a dependency on the
order the initialize functions are executed in.
Tested on x86_64-linux
Change-Id: I88eefebf7d372ad672f42d3a103e89354bc8a925
Diffstat (limited to 'gdb/testsuite/gdb.gdb')
-rw-r--r-- | gdb/testsuite/gdb.gdb/unittest.exp | 25 |
1 files changed, 23 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp index 46583cd..2967b99 100644 --- a/gdb/testsuite/gdb.gdb/unittest.exp +++ b/gdb/testsuite/gdb.gdb/unittest.exp @@ -58,11 +58,12 @@ proc run_selftests { binfile } { } -re "Selftests have been disabled for this build.\r\n$gdb_prompt $" { unsupported $test + set num_ran 0 set enabled 0 } } - return $enabled + return [list $enabled $num_ran] } # Test completion of command "maintenance selftest". @@ -86,7 +87,27 @@ proc_with_prefix test_completion {} { } with_test_prefix "no executable loaded" { - set self_tests_enabled [run_selftests ""] + set res [run_selftests ""] + set self_tests_enabled [lindex $res 0] + set num_ran [lindex $res 1] +} + +if { $self_tests_enabled && ![is_remote host] } { + # Check that we have the same amount of selftests whatever the + # initialization order of GDB. + with_test_prefix "reversed initialization" { + save_vars { env(GDB_REVERSE_INIT_FUNCTIONS) } { + if [info exists env(GDB_REVERSE_INIT_FUNCTIONS)] { + unset env(GDB_REVERSE_INIT_FUNCTIONS) + } else { + set env(GDB_REVERSE_INIT_FUNCTIONS) 1 + } + + set res [run_selftests ""] + gdb_assert "$num_ran == [lindex $res 1]" \ + "selftest not dependent on initialization order" + } + } } with_test_prefix "executable loaded" { |