diff options
author | Tom de Vries <tdevries@suse.de> | 2024-09-21 05:55:18 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2024-09-21 05:55:18 +0200 |
commit | f121b8cf753a7890ceb6533393e8fd242445e27d (patch) | |
tree | 6350b119e734674e28a1bb3bd35e6bf6f9f37aec /gdb/testsuite/gdb.dwarf2/implptrpiece.exp | |
parent | dfc2e69ba4a56fea8d748acba5f2b0069ad82618 (diff) | |
download | binutils-f121b8cf753a7890ceb6533393e8fd242445e27d.zip binutils-f121b8cf753a7890ceb6533393e8fd242445e27d.tar.gz binutils-f121b8cf753a7890ceb6533393e8fd242445e27d.tar.bz2 |
[gdb/testsuite] Drop -readnow in three gdb.dwarf2 test-cases
When running the testsuite in an enviroment simulating a stressed system, I
ran into timeouts in three test-cases in gdb.dwarf2:
- gdb.dwarf2/count.exp,
- gdb.dwarf2/implptrconst.exp, and
- gdb.dwarf2/implptrpiece.exp.
In all three cases, -readnow is used which results in symtabs being expanded for
the executable, /lib64/libc.so.6 and /lib64/ld-linux-x86-64.so.2.
We could address this by limiting the scope of -readnow to the executable, but
after reviewing the test-cases there doesn't seem to be a clear reason to use
-readnow.
Fix this by dropping the -readnow.
Tested on x86_64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/testsuite/gdb.dwarf2/implptrpiece.exp')
-rw-r--r-- | gdb/testsuite/gdb.dwarf2/implptrpiece.exp | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/gdb/testsuite/gdb.dwarf2/implptrpiece.exp b/gdb/testsuite/gdb.dwarf2/implptrpiece.exp index 585cd74..867789f 100644 --- a/gdb/testsuite/gdb.dwarf2/implptrpiece.exp +++ b/gdb/testsuite/gdb.dwarf2/implptrpiece.exp @@ -101,18 +101,11 @@ Dwarf::assemble $asm_file { } } -if { [build_executable ${testfile}.exp ${testfile} \ +if { [prepare_for_testing "failed to prepare" ${testfile} \ [list $srcfile $asm_file] {nodebug}] } { return -1 } -# We need --readnow because otherwise we never read in the CU we -# created above. -save_vars { GDBFLAGS } { - set GDBFLAGS "$GDBFLAGS -readnow" - clean_restart ${testfile} -} - if ![runto_main] { return -1 } |