diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 11:52:21 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 15:27:39 -0400 |
| commit | 4dfef5be6812dd7abfbc8f18e9c0384f2522b511 (patch) | |
| tree | 90aa986d915c17f2320655298e2799d3a2cd1841 /gdb/testsuite/gdb.compile | |
| parent | 2fed9db40b1179f62c6fb0f2cacfb0db6b50af46 (diff) | |
| download | binutils-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.zip binutils-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.gz binutils-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.bz2 | |
gdb/testsuite: make runto_main not pass no-message to runto
As follow-up to this discussion:
https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html
... make runto_main not pass no-message to runto. This means that if we
fail to run to main, for some reason, we'll emit a FAIL. This is the
behavior we want the majority of (if not all) the time.
Without this, we rely on tests logging a failure if runto_main fails,
otherwise. They do so in a very inconsisteny mannet, sometimes using
"fail", "unsupported" or "untested". The messages also vary widly.
This patch removes all these messages as well.
Also, remove a few "fail" where we call runto (and not runto_main). by
default (without an explicit no-message argument), runto prints a
failure already. In two places, gdb.multi/multi-re-run.exp and
gdb.python/py-pp-registration.exp, remove "message" passed to runto.
This removes a few PASSes that we don't care about (but FAILs will still
be printed if we fail to run to where we want to). This aligns their
behavior with the rest of the testsuite.
Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
Diffstat (limited to 'gdb/testsuite/gdb.compile')
9 files changed, 0 insertions, 9 deletions
diff --git a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp index 497c5ce..572206f 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp index 3c803b7..27b713b 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp index e5c9c03..de7c351 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-member.exp b/gdb/testsuite/gdb.compile/compile-cplus-member.exp index f6f570d..a702a25 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-member.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-member.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-method.exp b/gdb/testsuite/gdb.compile/compile-cplus-method.exp index 5fe026a..1c020aa 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-method.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-method.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp index 9d60290..7563784 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-nested.exp b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp index d418332..dc8e1d2 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-nested.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp index 745589b..b57d59b 100644 --- a/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp +++ b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing $testfile $testfile $srcfile \ } if {![runto_main]} { - untested "could not run to main" return -1 } diff --git a/gdb/testsuite/gdb.compile/compile-tls.exp b/gdb/testsuite/gdb.compile/compile-tls.exp index f65652f..980cfda 100644 --- a/gdb/testsuite/gdb.compile/compile-tls.exp +++ b/gdb/testsuite/gdb.compile/compile-tls.exp @@ -22,7 +22,6 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ clean_restart ${binfile} if ![runto_main] then { - fail "can't run to main" return 0 } |