diff options
author | Andrew Burgess <aburgess@redhat.com> | 2023-09-08 15:50:19 +0100 |
---|---|---|
committer | Andrew Burgess <aburgess@redhat.com> | 2023-09-28 15:33:13 +0100 |
commit | aac60a978e2620037e4b034386cbc6ef65f8e4aa (patch) | |
tree | 0bbe89210090323bdfa9eed2fcb6a3af0fcfc6d2 /gdb/symfile.c | |
parent | a2827364e2bf19910fa5a54364a594a5ba3033b8 (diff) | |
download | binutils-aac60a978e2620037e4b034386cbc6ef65f8e4aa.zip binutils-aac60a978e2620037e4b034386cbc6ef65f8e4aa.tar.gz binutils-aac60a978e2620037e4b034386cbc6ef65f8e4aa.tar.bz2 |
gdb: remove unnecessary notification of executable_changed observer
This commit continues the work of the previous two commits.
My goal, in the next couple of commits, is to expose the
executable_changed observable in the Python API as an event. However,
before I do that I want to remove the use of the executable_changed
observable from the reread_symbols function in symfile.c as this use
isn't directly associated with a change of the executable file, and so
seems wrong.
In the previous two commits I have removed all users of the
executable_changed observer as I believe those users can, and should,
actually be listening for the new_objfile observable instead, so now
there are no users of the executable_changed observable.
As such, I think removing the use of executable_changed from the
function reread_symbols is perfectly safe, and correct. At this point
the executable has not been changed, so we shouldn't be sending an
executable_changed notification, and, as there is nobody listening to
this observable, we can't break anything by removing this call.
There should be no user visible changes after this commit.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/symfile.c')
-rw-r--r-- | gdb/symfile.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/gdb/symfile.c b/gdb/symfile.c index 76b5e1b..47e8154 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2684,10 +2684,6 @@ reread_symbols (int from_tty) clear_symtab_users above. Notify the new files now. */ for (auto iter : new_objfiles) gdb::observers::new_objfile.notify (iter); - - /* At least one objfile has changed, so we can consider that - the executable we're debugging has changed too. */ - gdb::observers::executable_changed.notify (); } } |