diff options
author | Pedro Alves <palves@redhat.com> | 2009-08-13 18:27:56 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2009-08-13 18:27:56 +0000 |
commit | ecd0ada520284724373d81f3580cf1e15855b737 (patch) | |
tree | 15a0dd356349b582779ec9cfeab256fc95acb244 /gdb/remote.c | |
parent | 078bc676bddc06b18b54bcbc6954079be78bd897 (diff) | |
download | binutils-ecd0ada520284724373d81f3580cf1e15855b737.zip binutils-ecd0ada520284724373d81f3580cf1e15855b737.tar.gz binutils-ecd0ada520284724373d81f3580cf1e15855b737.tar.bz2 |
* remote.c (remote_pid_to_str): If printing a process id and we
don't know what the remote pid could be, output "Remote target";
otherwise, use normal_pid_to_str.
Diffstat (limited to 'gdb/remote.c')
-rw-r--r-- | gdb/remote.c | 45 |
1 files changed, 29 insertions, 16 deletions
diff --git a/gdb/remote.c b/gdb/remote.c index 797f3a6..69d1c5f 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7835,26 +7835,39 @@ remote_pid_to_str (struct target_ops *ops, ptid_t ptid) static char buf[64]; struct remote_state *rs = get_remote_state (); - if (ptid_equal (magic_null_ptid, ptid)) - { - xsnprintf (buf, sizeof buf, "Thread <main>"); - return buf; - } - else if (remote_multi_process_p (rs) - && ptid_get_tid (ptid) != 0 && ptid_get_pid (ptid) != 0) - { - xsnprintf (buf, sizeof buf, "Thread %d.%ld", - ptid_get_pid (ptid), ptid_get_tid (ptid)); - return buf; + if (ptid_is_pid (ptid)) + { + /* Printing an inferior target id. */ + + /* When multi-process extensions are off, there's no way in the + remote protocol to know the remote process id, if there's any + at all. There's one exception --- when we're connected with + target extended-remote, and we manually attached to a process + with "attach PID". We don't record anywhere a flag that + allows us to distinguish that case from the case of + connecting with extended-remote and the stub already being + attached to a process, and reporting yes to qAttached, hence + no smart special casing here. */ + if (!remote_multi_process_p (rs)) + { + xsnprintf (buf, sizeof buf, "Remote target"); + return buf; + } + + return normal_pid_to_str (ptid); } - else if (ptid_get_tid (ptid) != 0) + else { - xsnprintf (buf, sizeof buf, "Thread %ld", - ptid_get_tid (ptid)); + if (ptid_equal (magic_null_ptid, ptid)) + xsnprintf (buf, sizeof buf, "Thread <main>"); + else if (remote_multi_process_p (rs)) + xsnprintf (buf, sizeof buf, "Thread %d.%ld", + ptid_get_pid (ptid), ptid_get_tid (ptid)); + else + xsnprintf (buf, sizeof buf, "Thread %ld", + ptid_get_tid (ptid)); return buf; } - - return normal_pid_to_str (ptid); } /* Get the address of the thread local variable in OBJFILE which is |