diff options
| author | Tom Tromey <tom@tromey.com> | 2022-04-27 15:22:56 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-08-21 08:03:42 -0600 |
| commit | bdc8cfc1e43ebc4029cf130c678b9e1a4e4e5682 (patch) | |
| tree | 8bfc24e3261a01621b4c01020a35db142213c9de /gdb/python/python-internal.h | |
| parent | 12f26cb22e56ab8c26dd5a00f32158af561da4cb (diff) | |
| download | binutils-bdc8cfc1e43ebc4029cf130c678b9e1a4e4e5682.zip binutils-bdc8cfc1e43ebc4029cf130c678b9e1a4e4e5682.tar.gz binutils-bdc8cfc1e43ebc4029cf130c678b9e1a4e4e5682.tar.bz2 | |
Fix crash in gdbpy_parse_register_id
I noticed that gdbpy_parse_register_id would assert if passed a Python
object of a type it was not expecting. The included test case shows
this crash. This patch fixes the problem and also changes
gdbpy_parse_register_id to be more "Python-like" -- it always ensures
the Python error is set when it fails, and the callers now simply
propagate the existing exception.
Diffstat (limited to 'gdb/python/python-internal.h')
| -rw-r--r-- | gdb/python/python-internal.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 800b03a..d624b23 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -819,7 +819,8 @@ typedef std::unique_ptr<Py_buffer, Py_buffer_deleter> Py_buffer_up; If a register is parsed successfully then *REG_NUM will have been updated, and true is returned. Otherwise the contents of *REG_NUM are - undefined, and false is returned. + undefined, and false is returned. When false is returned, the + Python error is set. The PYO_REG_ID object can be a string, the name of the register. This is the slowest approach as GDB has to map the name to a number for each |