diff options
| author | Alan Hayward <alan.hayward@arm.com> | 2019-05-28 10:07:54 +0100 |
|---|---|---|
| committer | Alan Hayward <alan.hayward@arm.com> | 2019-05-28 10:07:54 +0100 |
| commit | 766f883622ef008230250aa5aecef9fb9b29f233 (patch) | |
| tree | e1302190a7dc0b839e38d03dfbc192af18701dd6 /gdb/inflow.c | |
| parent | 0f4a61b42002f568473f821f00dd240413beadd0 (diff) | |
| download | binutils-766f883622ef008230250aa5aecef9fb9b29f233.zip binutils-766f883622ef008230250aa5aecef9fb9b29f233.tar.gz binutils-766f883622ef008230250aa5aecef9fb9b29f233.tar.bz2 | |
Suppress SIGTTOU when handling errors
Calls to error () can cause SIGTTOU to send gdb to the background.
For example, on an Arm build:
(gdb) b main
Breakpoint 1 at 0x10774: file /build/gdb/testsuite/../../../src/binutils-gdb/gdb/testsuite/gdb.base/watchpoint.c, line 174.
(gdb) r
Starting program: /build/gdb/testsuite/outputs/gdb.base/watchpoint/watchpoint
[1]+ Stopped ../gdb ./outputs/gdb.base/watchpoint/watchpoint
localhost$ fg
../gdb ./outputs/gdb.base/watchpoint/watchpoint
Cannot parse expression `.L1199 4@r4'.
warning: Probes-based dynamic linker interface failed.
Reverting to original interface.
The SIGTTOU is raised whilst inside a syscall during the call to tcdrain.
Fix is to use scoped_ignore_sigttou to ensure SIGTTOU is blocked.
In addition fix include comments - job_control is not included via terminal.h
gdb/ChangeLog:
* event-top.c: Remove include comment.
* inflow.c (class scoped_ignore_sigttou): Move from here...
* inflow.h (class scoped_ignore_sigttou): ...to here.
* ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
* top.c: Remove include comment.
Diffstat (limited to 'gdb/inflow.c')
| -rw-r--r-- | gdb/inflow.c | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/gdb/inflow.c b/gdb/inflow.c index 339b55c..eba7a93 100644 --- a/gdb/inflow.c +++ b/gdb/inflow.c @@ -106,35 +106,6 @@ static serial_ttystate initial_gdb_ttystate; static struct terminal_info *get_inflow_inferior_data (struct inferior *); -/* RAII class used to ignore SIGTTOU in a scope. */ - -class scoped_ignore_sigttou -{ -public: - scoped_ignore_sigttou () - { -#ifdef SIGTTOU - if (job_control) - m_osigttou = signal (SIGTTOU, SIG_IGN); -#endif - } - - ~scoped_ignore_sigttou () - { -#ifdef SIGTTOU - if (job_control) - signal (SIGTTOU, m_osigttou); -#endif - } - - DISABLE_COPY_AND_ASSIGN (scoped_ignore_sigttou); - -private: -#ifdef SIGTTOU - sighandler_t m_osigttou = NULL; -#endif -}; - /* While the inferior is running, we want SIGINT and SIGQUIT to go to the inferior only. If we have job control, that takes care of it. If not, we save our handlers in these two variables and set SIGINT and SIGQUIT |