diff options
author | Tom Tromey <tom@tromey.com> | 2018-07-08 21:05:41 -0600 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2018-07-22 13:20:07 -0600 |
commit | a0de763e32b381369896fef63d221376f29a9113 (patch) | |
tree | 4471af9aa69c5ac073b1f4d3ef6255dd8b48266d /gdb/gdbserver | |
parent | 3b20124b3d6df31b5bde0f6bcd718cc40de8d49b (diff) | |
download | binutils-a0de763e32b381369896fef63d221376f29a9113.zip binutils-a0de763e32b381369896fef63d221376f29a9113.tar.gz binutils-a0de763e32b381369896fef63d221376f29a9113.tar.bz2 |
Add -Wunused-variable to warnings.m4
This adds -Wunused-variable to the build. This required a special
check in configure in order to work around a bug in GCC 4.9. Simon
ound the correct test to use, so I've added him to the ChangeLog.
gdb/ChangeLog
2018-07-22 Simon Marchi <simon.marchi@polymtl.ca>
Tom Tromey <tom@tromey.com>
* warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
test for it.
* configure: Rebuild.
gdb/gdbserver/ChangeLog
2018-07-22 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
Diffstat (limited to 'gdb/gdbserver')
-rw-r--r-- | gdb/gdbserver/ChangeLog | 4 | ||||
-rwxr-xr-x | gdb/gdbserver/configure | 28 |
2 files changed, 30 insertions, 2 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index eccf556..23369e4 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,9 @@ 2018-07-22 Tom Tromey <tom@tromey.com> + * configure: Rebuild. + +2018-07-22 Tom Tromey <tom@tromey.com> + * win32-low.c (win32_create_inferior): Remove unused variables. * gdbreplay.c (remote_open): Remove unused variable. * remote-utils.c (remote_prepare): Remove unused variable. diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 6064a1e..043bc21 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7237,7 +7237,7 @@ fi # The options we'll try to enable. build_warnings="-Wall -Wpointer-arith \ --Wno-unused -Wunused-value -Wunused-function \ +-Wno-unused -Wunused-value -Wunused-variable -Wunused-function \ -Wno-switch -Wno-char-subscripts \ -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \ -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized \ @@ -7326,7 +7326,30 @@ $as_echo_n "checking compiler warning flags... " >&6; } CFLAGS="$CFLAGS -Werror $wtest" saved_CXXFLAGS="$CXXFLAGS" CXXFLAGS="$CXXFLAGS -Werror $wtest" - cat confdefs.h - <<_ACEOF >conftest.$ac_ext + if test "x$w" = "x-Wunused-variable"; then + # Check for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38958, + # fixed in GCC 4.9. This test is derived from the gdb + # source code that triggered this bug in GCC. + cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ +struct scoped_restore_base {}; + struct scoped_restore_tmpl : public scoped_restore_base { + ~scoped_restore_tmpl() {} + }; +int +main () +{ +const scoped_restore_base &b = scoped_restore_tmpl(); + ; + return 0; +} +_ACEOF +if ac_fn_cxx_try_compile "$LINENO"; then : + WARN_CFLAGS="${WARN_CFLAGS} $w" +fi +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + else + cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ int @@ -7341,6 +7364,7 @@ if ac_fn_cxx_try_compile "$LINENO"; then : WARN_CFLAGS="${WARN_CFLAGS} $w" fi rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + fi CFLAGS="$saved_CFLAGS" CXXFLAGS="$saved_CXXFLAGS" esac |