diff options
| author | Iain Buclaw <ibuclaw@gdcproject.org> | 2017-03-30 10:43:03 +0200 |
|---|---|---|
| committer | Iain Buclaw <ibuclaw@gdcproject.org> | 2017-03-30 10:54:54 +0200 |
| commit | 662659a1a582af14aa45a458005e2a4df514b6d7 (patch) | |
| tree | 28064f6f9ca0f4a095d3c76d9e939763eae0d583 /gdb/d-exp.y | |
| parent | a62b75569b0e8038cf7c61350bf6fd5d0d6b64f8 (diff) | |
| download | binutils-662659a1a582af14aa45a458005e2a4df514b6d7.zip binutils-662659a1a582af14aa45a458005e2a4df514b6d7.tar.gz binutils-662659a1a582af14aa45a458005e2a4df514b6d7.tar.bz2 | |
Fix classification of `module.type' in D lexer.
The two-tier lexer in gdb/d-exp.y, which resolves fully qualified names
missed a case where `module.type' was not being classified as one token.
And so when the grammar takes over, it matched the remaining tokens
against the rule `TypeExp . IdentifierExp', where we were expecting to
instead match cast expression `( TypeExp ) UnaryExpression'.
Adding a case for TYPE_CODE_MODULE in type_aggregate_p means that
classify_inner_name will get a chance to lookup the symbol.
This was noticed when using `watch -l', and got the rather confusing
response:
A syntax error in expression, near `) 0x0add4e55'.
So it's been included in the testsuite, along with another test that
does effectively the same expression, but explicitly.
gdb/ChangeLog:
* d-exp.y (type_aggregate_p): Treat TYPE_CODE_MODULE as being
aggregate-like.
gdb/testsuite/ChangeLog:
* gdb.dlang/watch-loc.c: New file.
* gdb.dlang/watch-loc.exp: New file.
Diffstat (limited to 'gdb/d-exp.y')
| -rw-r--r-- | gdb/d-exp.y | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/d-exp.y b/gdb/d-exp.y index b526575..8625e41 100644 --- a/gdb/d-exp.y +++ b/gdb/d-exp.y @@ -648,6 +648,7 @@ type_aggregate_p (struct type *type) { return (TYPE_CODE (type) == TYPE_CODE_STRUCT || TYPE_CODE (type) == TYPE_CODE_UNION + || TYPE_CODE (type) == TYPE_CODE_MODULE || (TYPE_CODE (type) == TYPE_CODE_ENUM && TYPE_DECLARED_CLASS (type))); } |