diff options
| author | Tom Tromey <tromey@adacore.com> | 2025-08-06 07:14:56 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2025-08-06 07:22:11 -0600 |
| commit | 2f6db3e2e77d7e10b407fb43b13a985e9b4211ed (patch) | |
| tree | 463df82c189fa6e074a078299a5d0e57f636de95 /gdb/breakpoint.h | |
| parent | c2729c37f10af09126b2916215cae425ae724f55 (diff) | |
| download | binutils-2f6db3e2e77d7e10b407fb43b13a985e9b4211ed.zip binutils-2f6db3e2e77d7e10b407fb43b13a985e9b4211ed.tar.gz binutils-2f6db3e2e77d7e10b407fb43b13a985e9b4211ed.tar.bz2 | |
Revert "Call target_can_do_single_step from maybe_software_singlestep"
This reverts commit 14de1447c9c52c1bfc52588f8652836f66ac6c47.
An automated tester said that this patch caused a regression on
aarch64:
FAIL: gdb.arch/aarch64-atomic-inst.exp: Step through the ldxr/stxr sequence (timeout)
I looked into it a bit yesterday but couldn't see an obvious problem;
and it's somewhat of a pain to try to debug it at the moment.
Tom de Vries also noticed this and filed it in bugzilla. So, I'm
backing the patch out until I can port the failing test to the AdaCore
internal test suite in order to find out what went wrong.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28440
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33255
Diffstat (limited to 'gdb/breakpoint.h')
| -rw-r--r-- | gdb/breakpoint.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index e9201bc..9341112 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -1884,10 +1884,10 @@ extern void insert_single_step_breakpoint (struct gdbarch *, const address_space *, CORE_ADDR); -/* Try to setup for software single stepping. Return true if - target_resume() should use hardware single step. GDBARCH is the - current gdbarch. */ -extern bool maybe_software_singlestep (struct gdbarch *); +/* Insert all software single step breakpoints for the current frame. + Return true if any software single step breakpoints are inserted, + otherwise, return false. */ +extern int insert_single_step_breakpoints (struct gdbarch *); /* Check whether any hardware watchpoints have triggered or not, according to the target, and record it in each watchpoint's |