diff options
| author | Joel Brobecker <brobecker@adacore.com> | 2014-08-29 19:50:03 +0200 |
|---|---|---|
| committer | Joel Brobecker <brobecker@adacore.com> | 2014-09-10 06:30:58 -0700 |
| commit | deede10c775af571f72a37efa5b763b45334b19e (patch) | |
| tree | adf10d9de104d25379715abaf4708aa4a90e92b6 /gdb/ChangeLog | |
| parent | 7828a5f5fab040cdc007ce235c4c534aa777067b (diff) | |
| download | binutils-deede10c775af571f72a37efa5b763b45334b19e.zip binutils-deede10c775af571f72a37efa5b763b45334b19e.tar.gz binutils-deede10c775af571f72a37efa5b763b45334b19e.tar.bz2 | |
Ada subscripting of pointer to array with dynamic bounds
Consider a pointer to an array which dynamic bounds, described in
DWARF as follow:
<1><25>: Abbrev Number: 4 (DW_TAG_array_type)
<26> DW_AT_name : foo__array_type
[...]
<2><3b>: Abbrev Number: 5 (DW_TAG_subrange_type)
[...]
<40> DW_AT_lower_bound : 5 byte block: 97 38 1c 94 4
(DW_OP_push_object_address; DW_OP_lit8; DW_OP_minus;
DW_OP_deref_size: 4)
<46> DW_AT_upper_bound : 5 byte block: 97 34 1c 94 4
(DW_OP_push_object_address; DW_OP_lit4; DW_OP_minus;
DW_OP_deref_size: 4)
GDB is now able to correctly print the entire array, but not one
element of the array. Eg:
(gdb) p foo.three_ptr.all
$1 = (1, 2, 3)
(gdb) p foo.three_ptr.all(1)
Cannot access memory at address 0xfffffffff4123a0c
The problem occurs because we are missing a dynamic resolution of
the variable's array type when subscripting the array. What the current
code does is "fix"-ing the array type using the GNAT encodings, but
that operation ignores any of the array's dynamic properties.
This patch fixes the issue by using ada_value_ind to dereference
the array pointer, which takes care of the array type resolution.
It also continues to "fix" arrays described using GNAT encodings,
so backwards compatibility is preserved.
gdb/ChangeLog:
* ada-lang.c (ada_value_ptr_subscript): Remove parameter "type".
Adjust function implementation and documentation accordingly.
(ada_evaluate_subexp) <OP_FUNCALL>: Only assign "type" if
NOSIDE is EVAL_AVOID_SIDE_EFFECTS.
Update call to ada_value_ptr_subscript.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dynarr-ptr.exp: Add subscripting tests.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 82e3622..67f631d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2014-09-10 Joel Brobecker <brobecker@adacore.com> + * ada-lang.c (ada_value_ptr_subscript): Remove parameter "type". + Adjust function implementation and documentation accordingly. + (ada_evaluate_subexp) <OP_FUNCALL>: Only assign "type" if + NOSIDE is EVAL_AVOID_SIDE_EFFECTS. + Update call to ada_value_ptr_subscript. + +2014-09-10 Joel Brobecker <brobecker@adacore.com> + * ada-valprint.c (ada_value_print): Use VAL's enclosing type instead of VAL's type. |