diff options
| author | Jan Beulich <jbeulich@suse.com> | 2021-03-29 12:06:09 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2021-03-29 12:06:09 +0200 |
| commit | c8cad9d389b76d19449d9190122472fa465476e5 (patch) | |
| tree | a681f1e1c8e2db9d78bcd94ee540479e12067423 /gas | |
| parent | 5cdaf100252746303a09e904b37aafea4153d12c (diff) | |
| download | binutils-c8cad9d389b76d19449d9190122472fa465476e5.zip binutils-c8cad9d389b76d19449d9190122472fa465476e5.tar.gz binutils-c8cad9d389b76d19449d9190122472fa465476e5.tar.bz2 | |
x86: VPSADBW's source operands are also commutative
In commit 79dec6b7baa2 ("x86-64: optimize certain commutative
VEX-encoded insns") I missed the fact that there being subtraction
involved here doesn't matter, as absolute differences get summed up.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 6 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/x86-64-avx-swap-2.d | 4 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/x86-64-sse2avx.d | 1 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/x86-64-sse2avx.s | 1 |
4 files changed, 10 insertions, 2 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 01ab2e8..f733134 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,11 @@ 2021-03-29 Jan Beulich <jbeulich@suse.com> + * testsuite/gas/i386/x86-64-sse2avx.s: Add vpsadbw case. + * testsuite/gas/i386/x86-64-avx-swap-2.d. + testsuite/gas/i386/x86-64-sse2avx.d: Adjust expectations. + +2021-03-29 Jan Beulich <jbeulich@suse.com> + * config/tc-i386.c (optimize_encoding): Replace VEX-encoding checks by opcodespace ones. (insert_lfence_before): Likewise. diff --git a/gas/testsuite/gas/i386/x86-64-avx-swap-2.d b/gas/testsuite/gas/i386/x86-64-avx-swap-2.d index 513e80d..c34c658 100644 --- a/gas/testsuite/gas/i386/x86-64-avx-swap-2.d +++ b/gas/testsuite/gas/i386/x86-64-avx-swap-2.d @@ -69,7 +69,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: c5 8d f4 d6 vpmuludq %ymm6,%ymm14,%ymm2 [ ]*[a-f0-9]+: c4 c2 4d 28 d6 vpmuldq %ymm14,%ymm6,%ymm2 [ ]*[a-f0-9]+: c5 8d eb d6 vpor %ymm6,%ymm14,%ymm2 -[ ]*[a-f0-9]+: c4 c1 4d f6 d6 vpsadbw %ymm14,%ymm6,%ymm2 +[ ]*[a-f0-9]+: c5 8d f6 d6 vpsadbw %ymm6,%ymm14,%ymm2 [ ]*[a-f0-9]+: c4 c1 4d f8 d6 vpsubb %ymm14,%ymm6,%ymm2 [ ]*[a-f0-9]+: c4 c1 4d f9 d6 vpsubw %ymm14,%ymm6,%ymm2 [ ]*[a-f0-9]+: c4 c1 4d fa d6 vpsubd %ymm14,%ymm6,%ymm2 @@ -211,7 +211,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: c5 89 f4 d6 vpmuludq %xmm6,%xmm14,%xmm2 [ ]*[a-f0-9]+: c4 c2 49 28 d6 vpmuldq %xmm14,%xmm6,%xmm2 [ ]*[a-f0-9]+: c5 89 eb d6 vpor %xmm6,%xmm14,%xmm2 -[ ]*[a-f0-9]+: c4 c1 49 f6 d6 vpsadbw %xmm14,%xmm6,%xmm2 +[ ]*[a-f0-9]+: c5 89 f6 d6 vpsadbw %xmm6,%xmm14,%xmm2 [ ]*[a-f0-9]+: c4 c1 49 f8 d6 vpsubb %xmm14,%xmm6,%xmm2 [ ]*[a-f0-9]+: c4 c1 49 f9 d6 vpsubw %xmm14,%xmm6,%xmm2 [ ]*[a-f0-9]+: c4 c1 49 fa d6 vpsubd %xmm14,%xmm6,%xmm2 diff --git a/gas/testsuite/gas/i386/x86-64-sse2avx.d b/gas/testsuite/gas/i386/x86-64-sse2avx.d index c904a2b..d0e50c5 100644 --- a/gas/testsuite/gas/i386/x86-64-sse2avx.d +++ b/gas/testsuite/gas/i386/x86-64-sse2avx.d @@ -273,6 +273,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: c5 89 eb f6 vpor %xmm6,%xmm14,%xmm6 [ ]*[a-f0-9]+: c5 c9 eb 31 vpor \(%rcx\),%xmm6,%xmm6 [ ]*[a-f0-9]+: c5 c9 f6 f4 vpsadbw %xmm4,%xmm6,%xmm6 +[ ]*[a-f0-9]+: c5 89 f6 f6 vpsadbw %xmm6,%xmm14,%xmm6 [ ]*[a-f0-9]+: c5 c9 f6 31 vpsadbw \(%rcx\),%xmm6,%xmm6 [ ]*[a-f0-9]+: c4 e2 49 00 f4 vpshufb %xmm4,%xmm6,%xmm6 [ ]*[a-f0-9]+: c4 e2 49 00 31 vpshufb \(%rcx\),%xmm6,%xmm6 diff --git a/gas/testsuite/gas/i386/x86-64-sse2avx.s b/gas/testsuite/gas/i386/x86-64-sse2avx.s index 6b25314..8a45b1e 100644 --- a/gas/testsuite/gas/i386/x86-64-sse2avx.s +++ b/gas/testsuite/gas/i386/x86-64-sse2avx.s @@ -280,6 +280,7 @@ _start: por %xmm14,%xmm6 por (%rcx),%xmm6 psadbw %xmm4,%xmm6 + psadbw %xmm14,%xmm6 psadbw (%rcx),%xmm6 pshufb %xmm4,%xmm6 pshufb (%rcx),%xmm6 |