diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2018-08-27 15:41:09 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2018-08-27 15:42:14 -0700 |
commit | 90c745dc545408a6a3115ff97485672826649ade (patch) | |
tree | 852cc043ddd5910306b2530acdc72bfb718fb926 /gas | |
parent | 3bf9c013e4a7b72aaa7e242e163a776ad7347c26 (diff) | |
download | binutils-90c745dc545408a6a3115ff97485672826649ade.zip binutils-90c745dc545408a6a3115ff97485672826649ade.tar.gz binutils-90c745dc545408a6a3115ff97485672826649ade.tar.bz2 |
x86: Don't mask out the GNU_PROPERTY_X86_UINT32_VALID bit
Since only the GNU_PROPERTY_X86_UINT32_VALID bit may be set in data-only
relocatable objects which don't contain any instructions, linker
shouldn't mask out the GNU_PROPERTY_X86_UINT32_VALID bit when merging
GNU_PROPERTY_X86_XXX bits. Otherwise, linker output doesn't contain
GNU_PROPERTY_X86_XXX property with any data-only relocatable inputs.
This patch keeps the GNU_PROPERTY_X86_UINT32_VALID bit and updates
readelf to print "<None>" if GNU_PROPERTY_X86_XXX property only has
the GNU_PROPERTY_X86_UINT32_VALID bit.
bfd/
* elfxx-x86.c (_bfd_x86_elf_parse_gnu_properties): Don't mask
out the GNU_PROPERTY_X86_UINT32_VALID bit.
binutils/
* readelf.c (decode_x86_isa): Print <None> if bitmask only
contains the GNU_PROPERTY_X86_UINT32_VALID bit.
(decode_x86_feature_1): Likewise.
(decode_x86_feature_2): Likewise.
(print_gnu_property_note): Don't mask out the
GNU_PROPERTY_X86_UINT32_VALID bit.
* testsuite/binutils-all/i386/pr21231b.d: Updated.
* testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
gas/
* testsuite/gas/i386/i386.exp: Run property-1 and
x86-64-property-1.
* testsuite/gas/i386/property-1.d: New file.
* testsuite/gas/i386/property-1.s: Likewise.
* testsuite/gas/i386/x86-64-property-1.d: Likewise.
ld/
* testsuite/ld-i386/i386.exp: Run property-x86-5.
* testsuite/ld-i386/property-x86-5.d: New file.
* testsuite/ld-x86-64/property-x86-5-x32.d: Likewise.
* testsuite/ld-x86-64/property-x86-5.d: Likewise.
* testsuite/ld-x86-64/property-x86-5a.s: Likewise.
* testsuite/ld-x86-64/property-x86-5b.s: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run property-x86-5 and
property-x86-5-x32.
Diffstat (limited to 'gas')
-rw-r--r-- | gas/ChangeLog | 8 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/i386.exp | 2 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/property-1.d | 7 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/property-1.s | 31 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/x86-64-property-1.d | 9 |
5 files changed, 57 insertions, 0 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 42523c8..ef02ae4 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,11 @@ +2018-08-27 H.J. Lu <hongjiu.lu@intel.com> + + * testsuite/gas/i386/i386.exp: Run property-1 and + x86-64-property-1. + * testsuite/gas/i386/property-1.d: New file. + * testsuite/gas/i386/property-1.s: Likewise. + * testsuite/gas/i386/x86-64-property-1.d: Likewise. + 2018-08-23 Kito Cheng <kito@andestech.com> * config/tc-riscv.c (arg_lookup): Checking diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp index aa1a0f2..088fece 100644 --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -535,6 +535,7 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_32_check]] run_dump_test "nop-6" run_dump_test "evex-no-scale-32" + run_dump_test "property-1" if { [gas_64_check] } then { run_dump_test "att-regs" @@ -1032,6 +1033,7 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_64_check]] t run_dump_test "x86-64-nop-6" run_dump_test "evex-no-scale-64" + run_dump_test "x86-64-property-1" } set ASFLAGS "$old_ASFLAGS" diff --git a/gas/testsuite/gas/i386/property-1.d b/gas/testsuite/gas/i386/property-1.d new file mode 100644 index 0000000..3a4530b --- /dev/null +++ b/gas/testsuite/gas/i386/property-1.d @@ -0,0 +1,7 @@ +#name: i386 property 1 +#readelf: -n + +Displaying notes found in: .note.gnu.property + Owner Data size Description + GNU 0x[0-9a-f]+ NT_GNU_PROPERTY_TYPE_0 + Properties: x86 ISA used: <None> diff --git a/gas/testsuite/gas/i386/property-1.s b/gas/testsuite/gas/i386/property-1.s new file mode 100644 index 0000000..8857c11 --- /dev/null +++ b/gas/testsuite/gas/i386/property-1.s @@ -0,0 +1,31 @@ + .section ".note.gnu.property", "a" +.ifdef __64_bit__ + .p2align 3 +.else + .p2align 2 +.endif + .long 1f - 0f /* name length. */ + .long 3f - 1f /* data length. */ + /* NT_GNU_PROPERTY_TYPE_0 */ + .long 5 /* note type. */ +0: + .asciz "GNU" /* vendor name. */ +1: +.ifdef __64_bit__ + .p2align 3 +.else + .p2align 2 +.endif + /* GNU_PROPERTY_X86_ISA_1_USED */ + .long 0xc0010000 /* pr_type. */ + .long 5f - 4f /* pr_datasz. */ +4: + /* GNU_PROPERTY_X86_UINT32_VALID */ + .long 0x80000000 +5: +.ifdef __64_bit__ + .p2align 3 +.else + .p2align 2 +.endif +3: diff --git a/gas/testsuite/gas/i386/x86-64-property-1.d b/gas/testsuite/gas/i386/x86-64-property-1.d new file mode 100644 index 0000000..5fc1c85 --- /dev/null +++ b/gas/testsuite/gas/i386/x86-64-property-1.d @@ -0,0 +1,9 @@ +#name: x86-64 property 1 +#source: property-1.s +#as: -defsym __64_bit__=1 +#readelf: -n + +Displaying notes found in: .note.gnu.property + Owner Data size Description + GNU 0x[0-9a-f]+ NT_GNU_PROPERTY_TYPE_0 + Properties: x86 ISA used: <None> |