diff options
| author | Jan Beulich <jbeulich@suse.com> | 2020-06-08 08:40:22 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2020-06-08 08:40:22 +0200 |
| commit | 73c76375955890df396b4f78dee0fa6a52af6c5f (patch) | |
| tree | d1212a6fa9f5445e74c2f93b4ea962bdec8b13c8 /gas | |
| parent | 22e00a3f4df8cafd3fdb6a0cb7893877606518bb (diff) | |
| download | binutils-73c76375955890df396b4f78dee0fa6a52af6c5f.zip binutils-73c76375955890df396b4f78dee0fa6a52af6c5f.tar.gz binutils-73c76375955890df396b4f78dee0fa6a52af6c5f.tar.bz2 | |
x86: simplify check_byte_reg()
With the introduction of what right now is the very first conditional
in the function's loop (commit dc821c5f9ae5 ["x86: replace Reg8, Reg16,
Reg32, and Reg64"]), the last if() in the same loop has become
pointless - retain just its body.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/config/tc-i386.c | 19 |
2 files changed, 9 insertions, 15 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index d400081..27ffa3c 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,10 @@ 2020-06-08 Jan Beulich <jbeulich@suse.com> + * config/tc-i386.c (check_byte_reg): Drop dead conditional + around as_bad(). + +2020-06-08 Jan Beulich <jbeulich@suse.com> + * config/tc-i386.c (check_register): Split RegTR handling, to fail recognition also in 64-bit mode as well as with i586 or i686 explicitly enabled. diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index cfb3b99..e0ebf80 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -7132,21 +7132,10 @@ check_byte_reg (void) continue; /* Any other register is bad. */ - if (i.types[op].bitfield.class == Reg - || i.types[op].bitfield.class == RegMMX - || i.types[op].bitfield.class == RegSIMD - || i.types[op].bitfield.class == SReg - || i.types[op].bitfield.class == RegCR - || i.types[op].bitfield.class == RegDR - || i.types[op].bitfield.class == RegTR) - { - as_bad (_("`%s%s' not allowed with `%s%c'"), - register_prefix, - i.op[op].regs->reg_name, - i.tm.name, - i.suffix); - return 0; - } + as_bad (_("`%s%s' not allowed with `%s%c'"), + register_prefix, i.op[op].regs->reg_name, + i.tm.name, i.suffix); + return 0; } return 1; } |