diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2023-12-06 13:27:20 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2024-03-25 18:31:38 +0000 |
| commit | f9ee45c3a95ac37cf1c3f4ac6be34b9a53e306f4 (patch) | |
| tree | 68317009468f7447fe76531049e2a3ae18b261bf /binutils | |
| parent | ec483c2344f967708cfa71c84ef349b6951c1374 (diff) | |
| download | binutils-f9ee45c3a95ac37cf1c3f4ac6be34b9a53e306f4.zip binutils-f9ee45c3a95ac37cf1c3f4ac6be34b9a53e306f4.tar.gz binutils-f9ee45c3a95ac37cf1c3f4ac6be34b9a53e306f4.tar.bz2 | |
bfd: make _bfd_section_size_insane part of the public API
If a BFD user is making use of a function like
bfd_get_section_contents to read a section into a pre-allocated
buffer, then that BFD user might also want to make use of
_bfd_section_size_insane prior to allocating the buffer they intend to
use in order to validate that the buffer size that plan to allocate is
sane.
This commit makes _bfd_section_size_insane public, by renaming it to
bfd_section_size_insane.
I've updated the existing uses within bfd/, I don't believe this
function is used outside of bfd/ currently.
One place that I plan to make use of this function is in
gdb/gdb_bfd.c, in the function gdb_bfd_get_full_section_contents.
This change isn't included in this commit, but will come later if/when
this has been merged into bfd.
There should be no change in behaviour after this commit.
bfd/
* bfd-in2.h (bfd_section_size_insane): Add declaration.
* compress.c (bfd_get_full_section_contents): Update for new name
of _bfd_section_size_insane.
(bfd_init_section_compress_status): Likewise.
* dwarf2.c (read_section): Likewise.
(_bfd_dwarf2_slurp_debug_info): Likewise.
* libbfd.h (_bfd_section_size_insane): Remove declaration.
* section.c (_bfd_section_size_insane): Rename to ...
(bfd_section_size_insane): ... this.
binutils/
* readelf.c (uncompress_section_contents): Update comment to
account for new name of _bfd_section_size_insane.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/readelf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/binutils/readelf.c b/binutils/readelf.c index 26e152f..c100648 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -15902,7 +15902,7 @@ uncompress_section_contents (bool is_zstd, z_stream strm; int rc; - /* Similar to _bfd_section_size_insane() in the BFD library we expect an + /* Similar to bfd_section_size_insane() in the BFD library we expect an upper limit of ~10x compression. Any compression larger than that is thought to be due to fuzzing of the compression header. */ if (uncompressed_size > file_size * 10) |