diff options
| author | Alan Modra <amodra@gmail.com> | 2025-04-01 22:36:54 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2025-04-01 23:45:46 +1030 |
| commit | 6c3458a8b7ee7d39f070c7b2350851cb2110c65a (patch) | |
| tree | 164135552d3dd84fd5f1623ead3b3bccb377bb78 /binutils | |
| parent | 7bc46c997839cbcb02f987f4cbf776b7a3bcc6f8 (diff) | |
| download | binutils-6c3458a8b7ee7d39f070c7b2350851cb2110c65a.zip binutils-6c3458a8b7ee7d39f070c7b2350851cb2110c65a.tar.gz binutils-6c3458a8b7ee7d39f070c7b2350851cb2110c65a.tar.bz2 | |
PR32829, SEGV on objdump function debug_type_samep
u.kenum is always non-NULL, see debug_make_enum_type.
PR 32829
* debug.c (debug_type_samep): Correct incomplete enum test.
(debug_write_type): Remove dead code.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/debug.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/binutils/debug.c b/binutils/debug.c index dcc8ccd..465b18e 100644 --- a/binutils/debug.c +++ b/binutils/debug.c @@ -2554,9 +2554,6 @@ debug_write_type (struct debug_handle *info, case DEBUG_KIND_UNION_CLASS: return debug_write_class_type (info, fns, fhandle, type, tag); case DEBUG_KIND_ENUM: - if (type->u.kenum == NULL) - return (*fns->enum_type) (fhandle, tag, (const char **) NULL, - (bfd_signed_vma *) NULL); return (*fns->enum_type) (fhandle, tag, type->u.kenum->names, type->u.kenum->values); case DEBUG_KIND_POINTER: @@ -3097,9 +3094,9 @@ debug_type_samep (struct debug_handle *info, struct debug_type_s *t1, break; case DEBUG_KIND_ENUM: - if (t1->u.kenum == NULL) - ret = t2->u.kenum == NULL; - else if (t2->u.kenum == NULL) + if (t1->u.kenum->names == NULL) + ret = t2->u.kenum->names == NULL; + else if (t2->u.kenum->names == NULL) ret = false; else { |