aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-09-16 09:25:56 +0930
committerAlan Modra <amodra@gmail.com>2020-09-16 16:41:33 +0930
commitc1229f84a41a6aba5b7df1f4261a9336347b068a (patch)
tree29313ea61526ebbbea65e043d1fa296d930b34ee /bfd
parentec74481d7e4afbc89e3785d22659d3897af36956 (diff)
downloadbinutils-c1229f84a41a6aba5b7df1f4261a9336347b068a.zip
binutils-c1229f84a41a6aba5b7df1f4261a9336347b068a.tar.gz
binutils-c1229f84a41a6aba5b7df1f4261a9336347b068a.tar.bz2
Tidy elf_symbol_from
bfd/ * elf-bfd.h (elf_symbol_from): Remove unused ABFD parameter. * elf.c (ignore_section_sym, _bfd_elf_copy_private_symbol_data), (swap_out_syms): Adjust elf_symbol_from invocation. binutils/ * nm.c (print_symbol): Adjust elf_symbol_from invocation. * objcopy.c (is_hidden_symbol): Likewise. gas/ * config/obj-elf.c (obj_elf_visibility, elf_frob_symbol): Adjust elf_symbol_from invocation. * config/tc-aarch64.c (s_variant_pcs): Likewise. * config/tc-m68hc11.c (s_m68hc11_mark_symbol): Likewise. * config/tc-ppc.c (ppc_elf_localentry, ppc_force_relocation), (ppc_fix_adjustable): Likewise. * config/tc-xgate.c (xgate_frob_symbol): Likewise. ld/ * plugin.c (asymbol_from_plugin_symbol): Adjust elf_symbol_from invocation. opcodes/ * ppc-dis.c (ppc_symbol_is_valid): Adjust elf_symbol_from invocation.
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/elf-bfd.h2
-rw-r--r--bfd/elf.c8
3 files changed, 11 insertions, 5 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 09e4a5f..b01cd95 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,11 @@
2020-09-16 Alan Modra <amodra@gmail.com>
+ * elf-bfd.h (elf_symbol_from): Remove unused ABFD parameter.
+ * elf.c (ignore_section_sym, _bfd_elf_copy_private_symbol_data),
+ (swap_out_syms): Adjust elf_symbol_from invocation.
+
+2020-09-16 Alan Modra <amodra@gmail.com>
+
PR 26623
* elf-bfd.h (elf_symbol_from): Exclude synthetic symbols.
diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index 9b0a202..140a9859 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -791,7 +791,7 @@ struct elf_size_info {
(bfd *, const Elf_Internal_Rela *, bfd_byte *);
};
-#define elf_symbol_from(ABFD,S) \
+#define elf_symbol_from(S) \
((((S)->flags & BSF_SYNTHETIC) == 0 \
&& (S)->the_bfd != NULL \
&& (S)->the_bfd->xvec->flavour == bfd_target_elf_flavour \
diff --git a/bfd/elf.c b/bfd/elf.c
index 5a02f8d..0059402 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -4102,7 +4102,7 @@ ignore_section_sym (bfd *abfd, asymbol *sym)
if (sym->section == NULL)
return TRUE;
- type_ptr = elf_symbol_from (abfd, sym);
+ type_ptr = elf_symbol_from (sym);
return ((type_ptr != NULL
&& type_ptr->internal_elf_sym.st_shndx != 0
&& bfd_is_abs_section (sym->section))
@@ -8025,8 +8025,8 @@ _bfd_elf_copy_private_symbol_data (bfd *ibfd,
|| bfd_get_flavour (obfd) != bfd_target_elf_flavour)
return TRUE;
- isym = elf_symbol_from (ibfd, isymarg);
- osym = elf_symbol_from (obfd, osymarg);
+ isym = elf_symbol_from (isymarg);
+ osym = elf_symbol_from (osymarg);
if (isym != NULL
&& isym->internal_elf_sym.st_shndx != 0
@@ -8191,7 +8191,7 @@ swap_out_syms (bfd *abfd,
goto error_return;
}
- type_ptr = elf_symbol_from (abfd, syms[idx]);
+ type_ptr = elf_symbol_from (syms[idx]);
if ((flags & BSF_SECTION_SYM) == 0
&& bfd_is_com_section (syms[idx]->section))