diff options
| author | Thiago Jung Bauermann <thiago.bauermann@linaro.org> | 2024-01-10 19:08:36 -0300 |
|---|---|---|
| committer | Thiago Jung Bauermann <thiago.bauermann@linaro.org> | 2024-02-08 20:42:59 -0300 |
| commit | 0fbd03fda1b693422802ee96f37728dff60f552e (patch) | |
| tree | c0bc8bd285667720d28b616eabd8663c9d0492cd /bfd | |
| parent | 7f26d260ef76a4cb2873a7815bef187005528c19 (diff) | |
| download | binutils-0fbd03fda1b693422802ee96f37728dff60f552e.zip binutils-0fbd03fda1b693422802ee96f37728dff60f552e.tar.gz binutils-0fbd03fda1b693422802ee96f37728dff60f552e.tar.bz2 | |
gdb/testsuite: Fix testing of "info copying"
gdb.base/default.exp has an incomplete test for the "info copying" command,
as poetically pointed out by the FIXME removed by this patch.
The test omits the pattern argument to gdb_test, which causes it to just
check for a GDB prompt at the end of the command output.
The problem is that the command output is the whole GPLv3 license, which
due to its size causes the test to fail sometimes, making the testcase to
be out of sync with GDB's output and failing the tests that follow
it. E.g.,
FAIL: gdb.base/default.exp: info copying (timeout)
FAIL: gdb.base/default.exp: info display
FAIL: gdb.base/default.exp: info frame "f" abbreviation
PASS: gdb.base/default.exp: info frame
FAIL: gdb.base/default.exp: info files
FAIL: gdb.base/default.exp: info float
FAIL: gdb.base/default.exp: info functions
FAIL: gdb.base/default.exp: info locals
FAIL: gdb.base/default.exp: info program
FAIL: gdb.base/default.exp: info registers
FAIL: gdb.base/default.exp: info stack "s" abbreviation
Fix by by checking for a few excerpts at the beginning, middle and end of
the license text. This makes the test consume the command's output in
smallish chunks.
Reviewed-by: Keith Seitz <keiths@redhat.com>
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'bfd')
0 files changed, 0 insertions, 0 deletions