aboutsummaryrefslogtreecommitdiff
path: root/bfd/som.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-08-25 15:46:02 +0930
committerAlan Modra <amodra@gmail.com>2020-08-25 23:07:10 +0930
commit2186273ac4ba9fa4c56dc8c5d47ab3a7e358cec9 (patch)
tree634e3e92fd64cbe09af484fdd259d68a3873d976 /bfd/som.c
parentd3e0baddb206bc7c5ad5beb0c4ac3db8a5feb889 (diff)
downloadbinutils-2186273ac4ba9fa4c56dc8c5d47ab3a7e358cec9.zip
binutils-2186273ac4ba9fa4c56dc8c5d47ab3a7e358cec9.tar.gz
binutils-2186273ac4ba9fa4c56dc8c5d47ab3a7e358cec9.tar.bz2
PR26452, ASAN: som_compute_checksum som.c:4293
PR 26452 * som.c (som_compute_checksum): XOR 32-bit words in header, not unsigned long sized words.
Diffstat (limited to 'bfd/som.c')
-rw-r--r--bfd/som.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/bfd/som.c b/bfd/som.c
index 887d9b1..4f0a606 100644
--- a/bfd/som.c
+++ b/bfd/som.c
@@ -37,7 +37,7 @@ static bfd_boolean som_mkobject (bfd *);
static bfd_boolean som_is_space (asection *);
static bfd_boolean som_is_subspace (asection *);
static int compare_subspaces (const void *, const void *);
-static unsigned long som_compute_checksum (struct som_external_header *);
+static uint32_t som_compute_checksum (struct som_external_header *);
static bfd_boolean som_build_and_write_symbol_table (bfd *);
static unsigned int som_slurp_symbol_table (bfd *);
@@ -4281,14 +4281,15 @@ som_finish_writing (bfd *abfd)
/* Compute and return the checksum for a SOM file header. */
-static unsigned long
+static uint32_t
som_compute_checksum (struct som_external_header *hdr)
{
- unsigned long checksum, count, i;
- unsigned long *buffer = (unsigned long *) hdr;
+ size_t count, i;
+ uint32_t checksum;
+ uint32_t *buffer = (uint32_t *) hdr;
checksum = 0;
- count = sizeof (struct som_external_header) / 4;
+ count = sizeof (*hdr) / sizeof (*buffer);
for (i = 0; i < count; i++)
checksum ^= *(buffer + i);