aboutsummaryrefslogtreecommitdiff
path: root/bfd/plugin.c
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2021-07-06 06:21:54 -0700
committerH.J. Lu <hjl.tools@gmail.com>2021-07-07 07:44:39 -0700
commit7a30ac441a4e776e68399cb916c4731b5192e931 (patch)
tree6c117dae85d6a43e3ec89cbdc8a03751e4d6732c /bfd/plugin.c
parentb180e8298b2068c2a530c25d0d6c4f2be651e12e (diff)
downloadbinutils-7a30ac441a4e776e68399cb916c4731b5192e931.zip
binutils-7a30ac441a4e776e68399cb916c4731b5192e931.tar.gz
binutils-7a30ac441a4e776e68399cb916c4731b5192e931.tar.bz2
ld: Check archive only for archive member
Since plugin_maybe_claim calls bfd_close on the original input BFD if it isn't an archive member, pass NULL to bfd_plugin_close_file_descriptor to indicate that the BFD isn't an archive member. bfd/ PR ld/18028 * plugin.c (bfd_plugin_close_file_descriptor): Check archive only of abfd != NULL. (try_claim): Pass NULL to bfd_plugin_close_file_descriptor if it isn't an archive member. ld/ PR ld/18028 * plugin.c (plugin_input_file): Add comments for abfd and ibfd. (plugin_object_p): Set input->ibfd to NULL if it isn't an archive member.
Diffstat (limited to 'bfd/plugin.c')
-rw-r--r--bfd/plugin.c25
1 files changed, 13 insertions, 12 deletions
diff --git a/bfd/plugin.c b/bfd/plugin.c
index b3d6739..6cfa2b6 100644
--- a/bfd/plugin.c
+++ b/bfd/plugin.c
@@ -277,27 +277,26 @@ bfd_plugin_open_input (bfd *ibfd, struct ld_plugin_input_file *file)
return 1;
}
-/* Close the plugin file descriptor. */
+/* Close the plugin file descriptor FD. If ABFD isn't NULL, it is an
+ archive member. */
void
bfd_plugin_close_file_descriptor (bfd *abfd, int fd)
{
- bfd *iobfd;
-
- iobfd = abfd;
- while (iobfd->my_archive
- && !bfd_is_thin_archive (iobfd->my_archive))
- iobfd = iobfd->my_archive;
- if (iobfd == abfd)
+ if (abfd == NULL)
close (fd);
else
{
- iobfd->archive_plugin_fd_open_count--;
+ while (abfd->my_archive
+ && !bfd_is_thin_archive (abfd->my_archive))
+ abfd = abfd->my_archive;
+
+ abfd->archive_plugin_fd_open_count--;
/* Dup the archive plugin file descriptor for later use, which
will be closed by _bfd_archive_close_and_cleanup. */
- if (iobfd->archive_plugin_fd_open_count == 0)
+ if (abfd->archive_plugin_fd_open_count == 0)
{
- iobfd->archive_plugin_fd = dup (fd);
+ abfd->archive_plugin_fd = dup (fd);
close (fd);
}
}
@@ -314,7 +313,9 @@ try_claim (bfd *abfd)
&& current_plugin->claim_file)
{
current_plugin->claim_file (&file, &claimed);
- bfd_plugin_close_file_descriptor (abfd, file.fd);
+ bfd_plugin_close_file_descriptor ((abfd->my_archive != NULL
+ ? abfd : NULL),
+ file.fd);
}
return claimed;