aboutsummaryrefslogtreecommitdiff
path: root/bfd/pdp11.c
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2020-06-05 10:08:26 +0100
committerNick Clifton <nickc@redhat.com>2020-06-05 10:08:26 +0100
commit9c65eeacd88bc02aad537394930b48c50fb616d6 (patch)
tree9f0f70de0144e1c46ec2e6d5b18321b30be88175 /bfd/pdp11.c
parentd3d1cc7b13b4b1f11862d6b58174c81536fb3340 (diff)
downloadbinutils-9c65eeacd88bc02aad537394930b48c50fb616d6.zip
binutils-9c65eeacd88bc02aad537394930b48c50fb616d6.tar.gz
binutils-9c65eeacd88bc02aad537394930b48c50fb616d6.tar.bz2
Fix a use before initialization bug in the pdp11.c source file.
* pdp11.c (aout_link_add_symbols): Fix use before initialisation bug.
Diffstat (limited to 'bfd/pdp11.c')
-rw-r--r--bfd/pdp11.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/bfd/pdp11.c b/bfd/pdp11.c
index 2eca67c..fecaa21 100644
--- a/bfd/pdp11.c
+++ b/bfd/pdp11.c
@@ -2925,14 +2925,15 @@ aout_link_add_symbols (bfd *abfd, struct bfd_link_info *info)
type = H_GET_8 (abfd, p->e_type);
- /* Ignore debugging symbols. */
- if (is_stab(type, name))
- continue;
-
/* PR 19629: Corrupt binaries can contain illegal string offsets. */
if (GET_WORD (abfd, p->e_strx) >= obj_aout_external_string_size (abfd))
return FALSE;
name = strings + GET_WORD (abfd, p->e_strx);
+
+ /* Ignore debugging symbols. */
+ if (is_stab (type, name))
+ continue;
+
value = GET_WORD (abfd, p->e_value);
flags = BSF_GLOBAL;
string = NULL;