diff options
author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elfxx-sparc.c | |
parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
download | binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elfxx-sparc.c')
-rw-r--r-- | bfd/elfxx-sparc.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c index 6f5062b..4ab3ab8 100644 --- a/bfd/elfxx-sparc.c +++ b/bfd/elfxx-sparc.c @@ -2381,8 +2381,8 @@ _bfd_sparc_elf_omit_section_dynsym (bfd *output_bfd, /* Set the sizes of the dynamic sections. */ bool -_bfd_sparc_elf_size_dynamic_sections (bfd *output_bfd, - struct bfd_link_info *info) +_bfd_sparc_elf_late_size_sections (bfd *output_bfd, + struct bfd_link_info *info) { struct _bfd_sparc_elf_link_hash_table *htab; bfd *dynobj; @@ -2392,7 +2392,8 @@ _bfd_sparc_elf_size_dynamic_sections (bfd *output_bfd, htab = _bfd_sparc_elf_hash_table (info); BFD_ASSERT (htab != NULL); dynobj = htab->elf.dynobj; - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; if (elf_hash_table (info)->dynamic_sections_created) { |