diff options
author | Kito Cheng <kito.cheng@sifive.com> | 2020-07-06 19:30:36 -0700 |
---|---|---|
committer | Nelson Chu <nelson.chu@sifive.com> | 2020-09-03 11:11:38 +0800 |
commit | 72bd6912ea38224481f8bd0ed13b751e0fda4683 (patch) | |
tree | 0ba9c3c12bb03120fd7b2608423fb1523c48d533 /bfd/elfnn-riscv.c | |
parent | d48b742bc1a7af6a673e747c91bf7c72518a0b6a (diff) | |
download | binutils-72bd6912ea38224481f8bd0ed13b751e0fda4683.zip binutils-72bd6912ea38224481f8bd0ed13b751e0fda4683.tar.gz binutils-72bd6912ea38224481f8bd0ed13b751e0fda4683.tar.bz2 |
RISC-V: Improve the error message for the mis-matched ISA versions.
Consider the updated attr-merge-arch-failed-01.d testcase. Extension
A's version are mis-matched between attr-merge-arch-failed-01a.s and
attr-merge-arch-failed-01b.s. But the old binutils reports that the
mis-matched extension is M rather than A. This commit is used to fix
the wrong mis-matched error message.
Besides, when parsing the arch string in the riscv_parse_subset, it
shouldn't be NULL or empty. However, it might be empty when we failed
to merge the arch string in the riscv_merge_attributes. Since we should
already issue the correct error message in another side, and the message
- ISA string must begin with rv32 or rv64 - is meaninglesss when the arch
string is empty, so do not issue it.
bfd/
* elfnn-riscv.c (riscv_merge_std_ext): Fix to report the correct
error message when the versions of extension are mis-matched.
* elfxx-riscv.c (riscv_parse_subset): Don't issue the error when
the string is empty.
ld/
* testsuite/ld-riscv-elf/attr-merge-arch-failed-01.d: Updated.
* testsuite/ld-riscv-elf/attr-merge-arch-failed-01a.s: Likewise.
* testsuite/ld-riscv-elf/attr-merge-arch-failed-01b.s: Likewise.
Diffstat (limited to 'bfd/elfnn-riscv.c')
-rw-r--r-- | bfd/elfnn-riscv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index 8a3338c..f8de719 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -2724,7 +2724,7 @@ riscv_merge_std_ext (bfd *ibfd, && ((find_in->major_version != find_out->major_version) || (find_in->minor_version != find_out->minor_version))) { - riscv_version_mismatch (ibfd, in, out); + riscv_version_mismatch (ibfd, find_in, find_out); return FALSE; } |