diff options
| author | Alan Modra <amodra@gmail.com> | 2018-07-03 12:18:10 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-07-03 12:31:34 +0930 |
| commit | af0bfb9c4283ce80fe37ad6360d12cae8ec38696 (patch) | |
| tree | 6a33d1283583e37396b906469a95d4a0482286de /bfd/elflink.c | |
| parent | 1825c89e221b1bf80e73e858f1f2afcfe51272dd (diff) | |
| download | binutils-af0bfb9c4283ce80fe37ad6360d12cae8ec38696.zip binutils-af0bfb9c4283ce80fe37ad6360d12cae8ec38696.tar.gz binutils-af0bfb9c4283ce80fe37ad6360d12cae8ec38696.tar.bz2 | |
Hide dynamic symbols in discarded sections
This is a followup to git commit 97196564c7 "Strip global symbol
defined in discarded section". If a symbol defined in a discarded
section was dynamic, that patch left .dynsym with holes (ie. all zero
entries). For example, the following from libstdc++.so:
Symbol table '.dynsym' contains 6090 entries:
Num: Value Size Type Bind Vis Ndx Name
0: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND
1: 00000000000a74e0 0 SECTION LOCAL DEFAULT 10
2: 0000000000264180 0 SECTION LOCAL DEFAULT 17
3: 0000000000000000 0 NOTYPE WEAK DEFAULT UND _ITM_addUserCommitAction
4: 0000000000000000 0 NOTYPE WEAK DEFAULT UND _ITM_memcpyRtWn
5: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND
readelf: Warning: local symbol 5 found at index >= .dynsym's sh_info value of 3
6: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND
readelf: Warning: local symbol 6 found at index >= .dynsym's sh_info value of 3
[snip]
This patch removes the symbols from .dynsym too.
PR 17550
* elflink.c (_bfd_elf_fix_symbol_flags): Hide dynamic symbols
in discarded sections.
Diffstat (limited to 'bfd/elflink.c')
| -rw-r--r-- | bfd/elflink.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/bfd/elflink.c b/bfd/elflink.c index 36e0c37..e5592b0 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -2853,10 +2853,14 @@ _bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h, && (h->root.u.def.section->owner->flags & (DYNAMIC | BFD_PLUGIN)) == 0) h->def_regular = 1; + /* Symbols defined in discarded sections shouldn't be dynamic. */ + if (h->root.type == bfd_link_hash_undefined && h->indx == -3) + (*bed->elf_backend_hide_symbol) (eif->info, h, TRUE); + /* If a weak undefined symbol has non-default visibility, we also hide it from the dynamic linker. */ - if (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT - && h->root.type == bfd_link_hash_undefweak) + else if (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT + && h->root.type == bfd_link_hash_undefweak) (*bed->elf_backend_hide_symbol) (eif->info, h, TRUE); /* A hidden versioned symbol in executable should be forced local if |