diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-12-03 16:31:09 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-12-14 08:47:48 -0500 |
| commit | 9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a (patch) | |
| tree | a14d07055ccb22a4858f58147c5492ca55460425 /bfd/elf32-score.c | |
| parent | 78d4da9ae0d3447f28274a00b278f58ca7d8d1b2 (diff) | |
| download | binutils-9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a.zip binutils-9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a.tar.gz binutils-9bc8e54b1f1c281c7a4ecf49a4e9300e334beb0a.tar.bz2 | |
bfd: fix -Wunused errors with clang 13+
Clang 13 and 14 produce some -Wunused-but-set-{variable,parameter} for
situations where gcc doesn't. In particular, when a variable is set and
then used in a way to update its own value. For example, if `i` is only
used in this way:
int i = 2;
i++;
i = i + 1;
gcc won't warn, but clang will.
Fix all such errors found in an --enable-targets=all build. It would be
important for somebody who knows what they're doing to just make sure
that these variables can indeed be deleted, and that there a no cases
where it's a bug, and the variable should actually be used.
The first instance of this error fix by this patch is:
CC elf32-score.lo
/home/simark/src/binutils-gdb/bfd/elf32-score.c:450:11: error: variable 'relocation' set but not used [-Werror,-Wunused-but-set-variable]
bfd_vma relocation;
^
Change-Id: I2f233ce20352645cf388aff3dfa08a651d21a6b6
Diffstat (limited to 'bfd/elf32-score.c')
| -rw-r--r-- | bfd/elf32-score.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/bfd/elf32-score.c b/bfd/elf32-score.c index e8a7e63..cf2a3a4 100644 --- a/bfd/elf32-score.c +++ b/bfd/elf32-score.c @@ -440,23 +440,14 @@ score_elf_final_gp (bfd *output_bfd, static bfd_reloc_status_type score_elf_gprel15_with_gp (bfd *abfd, - asymbol *symbol, arelent *reloc_entry, asection *input_section, bool relocateable, void * data, bfd_vma gp ATTRIBUTE_UNUSED) { - bfd_vma relocation; unsigned long insn; - if (bfd_is_com_section (symbol->section)) - relocation = 0; - else - relocation = symbol->value; - - relocation += symbol->section->output_section->vma; - relocation += symbol->section->output_offset; if (reloc_entry->address > input_section->size) return bfd_reloc_outofrange; @@ -547,8 +538,8 @@ score_elf_gprel15_reloc (bfd *abfd, if (ret != bfd_reloc_ok) return ret; - return score_elf_gprel15_with_gp (abfd, symbol, reloc_entry, - input_section, relocateable, data, gp); + return score_elf_gprel15_with_gp (abfd, reloc_entry, + input_section, relocateable, data, gp); } /* Do a R_SCORE_GPREL32 relocation. This is a 32 bit value which must |