diff options
| author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
| commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
| tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elf32-cris.c | |
| parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
| download | binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 | |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elf32-cris.c')
| -rw-r--r-- | bfd/elf32-cris.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/bfd/elf32-cris.c b/bfd/elf32-cris.c index e2e402a..8b10dae 100644 --- a/bfd/elf32-cris.c +++ b/bfd/elf32-cris.c @@ -2525,7 +2525,7 @@ cris_elf_plt_sym_val (bfd_vma i ATTRIBUTE_UNUSED, const asection *plt, entry but we found we will not create any. Called when we find we will not have any PLT for this symbol, by for example elf_cris_adjust_dynamic_symbol when we're doing a proper dynamic link, - or elf_cris_size_dynamic_sections if no dynamic sections will be + or elf_cris_late_size_sections if no dynamic sections will be created (we're only linking static objects). */ static bool @@ -3506,8 +3506,8 @@ cris_elf_check_relocs (bfd *abfd, /* Set the sizes of the dynamic sections. */ static bool -elf_cris_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, - struct bfd_link_info *info) +elf_cris_late_size_sections (bfd *output_bfd ATTRIBUTE_UNUSED, + struct bfd_link_info *info) { struct elf_cris_link_hash_table * htab; bfd *dynobj; @@ -3519,7 +3519,8 @@ elf_cris_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, return false; dynobj = htab->root.dynobj; - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; if (htab->root.dynamic_sections_created) { @@ -4088,8 +4089,8 @@ elf_cris_got_elt_size (bfd *abfd ATTRIBUTE_UNUSED, elf_cris_adjust_dynamic_symbol #define elf_backend_copy_indirect_symbol \ elf_cris_copy_indirect_symbol -#define elf_backend_size_dynamic_sections \ - elf_cris_size_dynamic_sections +#define elf_backend_late_size_sections \ + elf_cris_late_size_sections #define elf_backend_init_index_section _bfd_elf_init_1_index_section #define elf_backend_finish_dynamic_symbol \ elf_cris_finish_dynamic_symbol |