diff options
| author | Guinevere Larsen <guinevere@redhat.com> | 2025-01-28 16:09:51 -0300 |
|---|---|---|
| committer | Guinevere Larsen <guinevere@redhat.com> | 2025-02-05 09:28:38 -0300 |
| commit | f8baffc3c0852eeffc63481ab2d1f9f9f70902ef (patch) | |
| tree | a512189cd675416e922371d43d64c7aa530d5f06 | |
| parent | f9978defb6fab0bd8583942d97c112b0932ac814 (diff) | |
| download | binutils-f8baffc3c0852eeffc63481ab2d1f9f9f70902ef.zip binutils-f8baffc3c0852eeffc63481ab2d1f9f9f70902ef.tar.gz binutils-f8baffc3c0852eeffc63481ab2d1f9f9f70902ef.tar.bz2 | |
gdb: restrict configure error with all targets and 64 bit bfd to mips
The recent commit b601c58034ed755fb765fc13782b6876bffd25d4 causes the
gdb configure to fail if --enable-targets=all was requested, but 64 bit
bfd was not enabled. This was due to a build failure first reported
against mips, and that I also encountered building on a 32 bit mips
system, but that looked like a general failure.
Further examination showed that this is, in fact, mips-specific (or at
least, not completely generic) as other targets like debian-i386 and
32-bit arm could build all targets just fine.
This commit restricts the new error to only trigger in mips hosts.
Approved-By: Andrew Burgess <aburgess@redhat.com>
| -rwxr-xr-x | gdb/configure | 13 | ||||
| -rw-r--r-- | gdb/configure.ac | 13 |
2 files changed, 20 insertions, 6 deletions
diff --git a/gdb/configure b/gdb/configure index cfb4f44..bdc405e 100755 --- a/gdb/configure +++ b/gdb/configure @@ -25005,9 +25005,16 @@ if test x${all_targets} = xtrue; then if test x${enable_64_bit_bfd} = xyes; then TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)' else - # If all targets were requested, but 64 bit bfd is not enabled, - # the build will fail. See PR 28684. - as_fn_error $? "--enable-targets=all requires --enable-64-bit-bfd" "$LINENO" 5 + case ${host} in + mips*) + # If all targets were requested, but 64 bit bfd is not enabled, + # the build will fail. See PR 28684. + as_fn_error $? "--enable-targets=all requires --enable-64-bit-bfd" "$LINENO" 5 + ;; + *) + TARGET_OBS='$(ALL_TARGET_OBS)' + ;; + esac fi fi diff --git a/gdb/configure.ac b/gdb/configure.ac index 77f774e..fb77e79 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -257,9 +257,16 @@ if test x${all_targets} = xtrue; then if test x${enable_64_bit_bfd} = xyes; then TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)' else - # If all targets were requested, but 64 bit bfd is not enabled, - # the build will fail. See PR 28684. - AC_MSG_ERROR([--enable-targets=all requires --enable-64-bit-bfd]) + case ${host} in + mips*) + # If all targets were requested, but 64 bit bfd is not enabled, + # the build will fail. See PR 28684. + AC_MSG_ERROR([--enable-targets=all requires --enable-64-bit-bfd]) + ;; + *) + TARGET_OBS='$(ALL_TARGET_OBS)' + ;; + esac fi fi |