diff options
| author | Tom de Vries <tdevries@suse.de> | 2021-02-10 11:43:46 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2021-02-10 11:43:46 +0100 |
| commit | ee4c3d88019ed88c3110e22cda16891aed14f818 (patch) | |
| tree | beedf71dfd843c914422c053ab4df38d9ffbfe2f | |
| parent | 01e8b831f588e706ced57b57cc0ed05c14da61ea (diff) | |
| download | binutils-ee4c3d88019ed88c3110e22cda16891aed14f818.zip binutils-ee4c3d88019ed88c3110e22cda16891aed14f818.tar.gz binutils-ee4c3d88019ed88c3110e22cda16891aed14f818.tar.bz2 | |
[gdb/testsuite] Fix tcl ERROR in gdb_load_no_complaints
In commit cf2b2075299 "[gdb/symtab] Fix element type modification in
read_array_type" I factored out new proc with_complaints out of proc
gdb_load_no_complaints, but when fixing a rebase conflict pre-commit I made a
mistake in gdb_load_no_complaints that is now causing:
...
ERROR: tcl error sourcing dw2-ranges-psym.exp.
ERROR: can't read "save": no such variable
while executing
"gdb_test_no_output "set complaints $save" """
(procedure "gdb_load_no_complaints" line 14)
invoked from within
"gdb_load_no_complaints $binfile"
...
Fix this by removing the offending line.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2021-02-10 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary
"Restore saved setting of complaints".
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 714c91f..881f111 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-02-10 Tom de Vries <tdevries@suse.de> + + * lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary + "Restore saved setting of complaints". + 2021-02-09 Tom de Vries <tdevries@suse.de> PR symtab/27341 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1406b91..016c678 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5149,9 +5149,6 @@ proc gdb_load_no_complaints { arg } { # Verify that there were no complaints. set re "^Reading symbols from \[^\r\n\]*\r\n$gdb_prompt $" gdb_assert {[regexp $re $gdb_file_cmd_msg]} "No complaints" - - # Restore saved setting of complaints. - gdb_test_no_output "set complaints $save" "" } # gdb_reload -- load a file into the target. Called before "running", |