aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2011-01-05 17:13:36 +0000
committerMike Frysinger <vapier@gentoo.org>2011-01-05 17:13:36 +0000
commitcc25892bf4b18282d58c4d8a3e85705142ba7ec0 (patch)
tree9c7bbed4ad8a302177c157c8905d6ed54f32897f
parentcc322803a5a55e75c91b5ad1fd210b79c4a49959 (diff)
downloadbinutils-cc25892bf4b18282d58c4d8a3e85705142ba7ec0.zip
binutils-cc25892bf4b18282d58c4d8a3e85705142ba7ec0.tar.gz
binutils-cc25892bf4b18282d58c4d8a3e85705142ba7ec0.tar.bz2
sim: tweak load buffer type to avoid signed warnings
The sim_load_file func creates a buffer with arbitrary data in it (reads it via the bfd). It then passes it on to a sim_write_fn which expects a unsigned char buffer. Since sim_load_file itself doesn't care about the contents, tweak the type to avoid signed mismatch warnings from gcc: common/sim-load.c: In function ‘sim_load_file’: common/sim-load.c:143: warning: pointer targets in passing argument 3 of ‘do_write’ differ in signedness common/sim-load.c:143: note: expected ‘const unsigned char *’ but argument is of type ‘char *’ Signed-off-by: Mike Frysinger <vapier@gentoo.org>
-rw-r--r--sim/common/ChangeLog4
-rw-r--r--sim/common/sim-load.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index f4779ad..ea0ce20 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,3 +1,7 @@
+2011-01-05 Mike Frysinger <vapier@gentoo.org>
+
+ * sim-load.c (sim_load_file): Change buffer type to unsigned char *.
+
2011-01-05 Joel Brobecker <brobecker@adacore.com>
* run.1: Copyright year update.
diff --git a/sim/common/sim-load.c b/sim/common/sim-load.c
index ee794ce..698d1c1 100644
--- a/sim/common/sim-load.c
+++ b/sim/common/sim-load.c
@@ -111,7 +111,7 @@ sim_load_file (sd, myname, callback, prog, prog_bfd, verbose_p, lma_p, do_write)
size = bfd_get_section_size (s);
if (size > 0)
{
- char *buffer;
+ unsigned char *buffer;
bfd_vma lma;
buffer = malloc (size);