diff options
author | Tom de Vries <tdevries@suse.de> | 2021-09-13 21:41:13 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2021-09-13 21:41:13 +0200 |
commit | c5e91131d790aa68787d886fe8f9c135a095f5b0 (patch) | |
tree | 0ed7eda69376df79efffd3b238b1176e38451b4b | |
parent | 3047c7869d38d4d7f84720d815d31085f3c788fa (diff) | |
download | binutils-c5e91131d790aa68787d886fe8f9c135a095f5b0.zip binutils-c5e91131d790aa68787d886fe8f9c135a095f5b0.tar.gz binutils-c5e91131d790aa68787d886fe8f9c135a095f5b0.tar.bz2 |
[gdb/testsuite] Check for valid test name
When running gdb.base/batch-exit-status.exp I noticed that the test name
contains a newline:
...
PASS: gdb.base/batch-exit-status.exp: : No such file or directory\.^M
: No such file or directory\.: [lindex $result 2] == 0
...
Check for this in ::CheckTestNames::check, such that we have a warning:
...
PASS: gdb.base/batch-exit-status.exp: : No such file or directory\.^M
: No such file or directory\.: [lindex $result 2] == 0
WARNING: Newline in test name
...
Tested on x86_64-linux.
-rw-r--r-- | gdb/testsuite/lib/check-test-names.exp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/gdb/testsuite/lib/check-test-names.exp b/gdb/testsuite/lib/check-test-names.exp index 1de7624..e2ac5bd 100644 --- a/gdb/testsuite/lib/check-test-names.exp +++ b/gdb/testsuite/lib/check-test-names.exp @@ -93,6 +93,13 @@ namespace eval ::CheckTestNames { return $message } + # Check if MESSAGE is a well-formed test name. + proc _check_well_formed_name { message } { + if { [regexp \n $message]} { + warning "Newline in test name" + } + } + # Check if MESSAGE contains either the source path or the build path. # This will result in test names that can't easily be compared between # different runs of GDB. @@ -110,6 +117,8 @@ namespace eval ::CheckTestNames { if [ _check_duplicates $message ] { clone_output "DUPLICATE: $message" } + + _check_well_formed_name $message } # If COUNT is greater than zero, disply PREFIX followed by COUNT. |