diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2025-02-08 21:32:05 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2025-02-10 20:57:12 +0000 |
| commit | c5ac7c9f7c97d2c1f7e9a44b66451e598774e547 (patch) | |
| tree | 959cb23b5f85888e1eede1d7e7268eb100c7b083 | |
| parent | f35bb15bed4ef1179f6c54654a590c825e53c3dc (diff) | |
| download | binutils-c5ac7c9f7c97d2c1f7e9a44b66451e598774e547.zip binutils-c5ac7c9f7c97d2c1f7e9a44b66451e598774e547.tar.gz binutils-c5ac7c9f7c97d2c1f7e9a44b66451e598774e547.tar.bz2 | |
gdb/tui: remove unnecessary wmove call from tui_status_window
I've been looking recently at when the TUI calls wnoutrefresh vs
wrefresh, and the ordering of other screen update actions relative to
these calls.
I noticed in tui_status_window::rerender() a call to wmove() that is
placed after the refresh_window() call. This surely means that the
cursor is moved, but, this update is not sent to the screen.
But we call wmove() at the start of tui_status_window::rerender()
before anything is sent to the screen, so the final wmove() call is
pointless as far as I can tell.
I propose removing it. This is trivial, but removing pointless work
like this slowly makes the TUI code easier to understand.
There should be no user visible changes after this commit.
Approved-By: Tom Tromey <tom@tromey.com>
| -rw-r--r-- | gdb/tui/tui-status.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/tui/tui-status.c b/gdb/tui/tui-status.c index 5239415..d76c2db 100644 --- a/gdb/tui/tui-status.c +++ b/gdb/tui/tui-status.c @@ -253,8 +253,8 @@ tui_status_window::rerender () waddstr (handle.get (), string.c_str ()); wclrtoeol (handle.get ()); (void) wstandend (handle.get ()); + refresh_window (); - wmove (handle.get (), 0, 0); } /* Function to print the frame information for the TUI. The windows |