diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2024-12-05 12:41:21 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2025-02-04 12:59:49 -0500 |
commit | 874162eb9fc8c067ebbaa1e56fad5d6ca5c93e63 (patch) | |
tree | aab0ce662a0fbd76942b3e06fdf48c861b53d3ba | |
parent | 8cfa1fc43e17c6c225afd7016b7e4e741e7e1ad7 (diff) | |
download | binutils-874162eb9fc8c067ebbaa1e56fad5d6ca5c93e63.zip binutils-874162eb9fc8c067ebbaa1e56fad5d6ca5c93e63.tar.gz binutils-874162eb9fc8c067ebbaa1e56fad5d6ca5c93e63.tar.bz2 |
pre-commit: run flake8 on more Python files
pre-commit currently runs flake8 only on `gdb/python/**/*.py`. There
are more files we can run it on, without running it on all the testsuite
files. Add:
- gdb/gdb-gdb.py.in
- gdb/*.py
- gdb/testsuite/*.py
Fix the new errors that popped up:
gdb/copyright.py:29:21: W605 invalid escape sequence '\*'
gdb/copyright.py:29:29: W605 invalid escape sequence '\*'
gdb/copyright.py:29:38: W605 invalid escape sequence '\*'
gdb/copyright.py:29:46: W605 invalid escape sequence '\*'
gdb/copyright.py:34:1: F401 'datetime' imported but unused
gdb/testsuite/analyze-racy-logs.py:150:9: E722 do not use bare 'except'
Change-Id: Ia864c22d4f170d4e18ce3beb06a86c49966654b2
Approved-By: Tom Tromey <tom@tromey.com>
-rw-r--r-- | .pre-commit-config.yaml | 11 | ||||
-rwxr-xr-x | gdb/copyright.py | 25 | ||||
-rwxr-xr-x | gdb/testsuite/analyze-racy-logs.py | 2 |
3 files changed, 21 insertions, 17 deletions
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 29f7f64..eed31d7 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -49,9 +49,14 @@ repos: hooks: - id: flake8 types_or: [file] - # Note this one is only run on gdb/python, not (for now) the - # test suite. - files: 'gdb/python/.*\.py(\.in)?$' + # Run this for (in glob notation): + # + # - gdb/gdb-gdb.py.in + # - gdb/*.py + # - gdb/python/**/*.py + # - gdb/testsuite/*.py + # + files: '^gdb/(gdb-gdb\.py\.in|[^/]+\.py|python/.+\.py|testsuite/[^/]+\.py)$' args: [--config, gdb/setup.cfg] - repo: https://github.com/pycqa/isort rev: 6.0.0 diff --git a/gdb/copyright.py b/gdb/copyright.py index 2c9ea3c..1a155b9 100755 --- a/gdb/copyright.py +++ b/gdb/copyright.py @@ -17,21 +17,20 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -"""copyright.py - -This script updates the list of years in the copyright notices in -most files maintained by the GDB project. - -Usage: cd src/gdb && ./copyright.py - -Always review the output of this script before committing it! -A useful command to review the output is: - % filterdiff -x \*.c -x \*.cc -x \*.h -x \*.exp updates.diff -This removes the bulk of the changes which are most likely to be correct. -""" +# This script updates the list of years in the copyright notices in +# most files maintained by the GDB project. +# +# Usage: cd src/gdb && ./copyright.py +# +# Always review the output of this script before committing it! +# +# A useful command to review the output is: +# +# $ filterdiff -x \*.c -x \*.cc -x \*.h -x \*.exp updates.diff +# +# This removes the bulk of the changes which are most likely to be correct. import argparse -import datetime import locale import os import os.path diff --git a/gdb/testsuite/analyze-racy-logs.py b/gdb/testsuite/analyze-racy-logs.py index 5a3f90e..3863bd0 100755 --- a/gdb/testsuite/analyze-racy-logs.py +++ b/gdb/testsuite/analyze-racy-logs.py @@ -147,7 +147,7 @@ def identify_racy_tests(): for s1, s2 in ignore_relations.items(): try: ignored_tests |= all_tests[s1] & all_tests[s2] - except: + except Exception: continue racy_tests: set[str] = set() |