aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLancelot SIX <lancelot.six@amd.com>2023-03-10 15:34:26 +0000
committerLancelot SIX <lancelot.six@amd.com>2023-07-19 09:47:20 +0100
commit81dd93c85623960bf4b1f7c2e2d297a333e2ec52 (patch)
treed097fa8c045f614683a8a80d846a505c3dbe5465
parent0d332f11122473192a944230e1d925bac115ca0d (diff)
downloadbinutils-81dd93c85623960bf4b1f7c2e2d297a333e2ec52.zip
binutils-81dd93c85623960bf4b1f7c2e2d297a333e2ec52.tar.gz
binutils-81dd93c85623960bf4b1f7c2e2d297a333e2ec52.tar.bz2
gdb/amd-dbgapi-target: Use inf param in detach
Current implementation of amd_dbgapi_target::detach (inferior *, int) does the following: remove_breakpoints_inf (current_inferior ()); detach_amd_dbgapi (inf); beneath ()->detach (inf, from_tty); I find that using a mix of `current_inferior ()` and `inf` disturbing. At this point, we know that both are the same (target_detach does assert that `inf == current_inferior ()` before calling target_ops::detach). To improve consistency, this patch replaces `current_inferior ()` with `inf` in amd_dbgapi_target::detach. Change-Id: I01b7ba2e661c25839438354b509d7abbddb7c5ed Approved-By: Pedro Alves <pedro@palves.net>
-rw-r--r--gdb/amd-dbgapi-target.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
index 5565cf9..40f24b5 100644
--- a/gdb/amd-dbgapi-target.c
+++ b/gdb/amd-dbgapi-target.c
@@ -1463,7 +1463,7 @@ amd_dbgapi_target::detach (inferior *inf, int from_tty)
Breakpoints may still be inserted because the inferior may be running in
non-stop mode, or because GDB changed the default setting to leave all
breakpoints inserted in all-stop mode when all threads are stopped. */
- remove_breakpoints_inf (current_inferior ());
+ remove_breakpoints_inf (inf);
detach_amd_dbgapi (inf);
beneath ()->detach (inf, from_tty);