diff options
| author | Tom Tromey <tom@tromey.com> | 2019-06-16 11:29:45 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-06-25 07:48:29 -0600 |
| commit | 7778b9128f46b1bb7af965ae3821f63b05c627ef (patch) | |
| tree | 954e2b9bb0870ce9e1bb5a487029dcad2d1bc695 | |
| parent | f83d391c5aa3304faf8ef1384a6c64f082653260 (diff) | |
| download | binutils-7778b9128f46b1bb7af965ae3821f63b05c627ef.zip binutils-7778b9128f46b1bb7af965ae3821f63b05c627ef.tar.gz binutils-7778b9128f46b1bb7af965ae3821f63b05c627ef.tar.bz2 | |
Remove tui_clear_win_detail
An earlier patch changed the context of the sole call to
tui_clear_win_detail to make it clear that this can never be called
with a NULL window pointer. So, remove tui_clear_win_detail in favor
of calling the method directly.
gdb/ChangeLog
2019-06-25 Tom Tromey <tom@tromey.com>
* tui/tui-data.h (tui_clear_win_detail): Don't declare.
* tui/tui-data.c (tui_clear_source_windows_detail): Call the
clear_detail method directly.
(tui_clear_win_detail): Remove.
| -rw-r--r-- | gdb/ChangeLog | 7 | ||||
| -rw-r--r-- | gdb/tui/tui-data.c | 11 | ||||
| -rw-r--r-- | gdb/tui/tui-data.h | 1 |
3 files changed, 8 insertions, 11 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 56b49cd..18bffd1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2019-06-25 Tom Tromey <tom@tromey.com> + * tui/tui-data.h (tui_clear_win_detail): Don't declare. + * tui/tui-data.c (tui_clear_source_windows_detail): Call the + clear_detail method directly. + (tui_clear_win_detail): Remove. + +2019-06-25 Tom Tromey <tom@tromey.com> + * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use "this", not TUI_DISASM_WIN. diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index 1edf40b..1e1bc03 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -159,7 +159,7 @@ void tui_clear_source_windows_detail () { for (tui_win_info *win : tui_source_windows ()) - tui_clear_win_detail (win); + win->clear_detail (); } @@ -205,15 +205,6 @@ tui_data_window::clear_detail () detail.data_display_info.display_regs = FALSE; } -/* Clear the pertinant detail in the windows. */ -void -tui_clear_win_detail (struct tui_win_info *win_info) -{ - if (win_info != NULL) - win_info->clear_detail (); -} - - /* Accessor for the source execution info ptr. */ struct tui_gen_win_info * tui_source_exec_info_win_ptr (void) diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index 4170f24..c4ef455 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -439,7 +439,6 @@ extern struct tui_gen_win_info *tui_disassem_exec_info_win_ptr (void); extern std::vector<tui_win_info *> &tui_source_windows (); extern void tui_clear_source_windows (void); extern void tui_clear_source_windows_detail (void); -extern void tui_clear_win_detail (struct tui_win_info *); extern void tui_add_to_source_windows (struct tui_win_info *); extern struct tui_win_info *tui_win_with_focus (void); extern void tui_set_win_with_focus (struct tui_win_info *); |