diff options
| author | Maciej W. Rozycki <macro@linux-mips.org> | 2005-02-07 02:44:59 +0000 |
|---|---|---|
| committer | Maciej W. Rozycki <macro@linux-mips.org> | 2005-02-07 02:44:59 +0000 |
| commit | 765f2ef6956841baed46e6203a7b9be1b248285c (patch) | |
| tree | 2b16e11328f25373f20edf2a18cb0c4be27b7c25 | |
| parent | 74e5ef4498ddf857524927fda93a56c5875d5adf (diff) | |
| download | binutils-765f2ef6956841baed46e6203a7b9be1b248285c.zip binutils-765f2ef6956841baed46e6203a7b9be1b248285c.tar.gz binutils-765f2ef6956841baed46e6203a7b9be1b248285c.tar.bz2 | |
* elf32-mips.c (mips_elf_gprel32_reloc): Reject
R_MIPS_GPREL32 relocations against external symbols.
* elf64-mips.c (mips_elf64_gprel32_reloc): Replace an incorrect
comment.
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/elf32-mips.c | 10 | ||||
| -rw-r--r-- | bfd/elf64-mips.c | 3 |
3 files changed, 18 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index b13e41c..033bf57 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2005-02-07 Maciej W. Rozycki <macro@mips.com> + + * elf32-mips.c (mips_elf_gprel32_reloc): Reject + R_MIPS_GPREL32 relocations against external symbols. + * elf64-mips.c (mips_elf64_gprel32_reloc): Replace an incorrect + comment. + 2005-02-07 Alan Modra <amodra@bigpond.net.au> * elf-bfd.h (elf_string_from_elf_strtab): Delete macro. diff --git a/bfd/elf32-mips.c b/bfd/elf32-mips.c index 9774215..07d8ba4 100644 --- a/bfd/elf32-mips.c +++ b/bfd/elf32-mips.c @@ -800,6 +800,16 @@ mips_elf_gprel32_reloc (bfd *abfd, arelent *reloc_entry, asymbol *symbol, bfd_reloc_status_type ret; bfd_vma gp; + /* R_MIPS_GPREL32 relocations are defined for local symbols only. */ + if (output_bfd != NULL + && (symbol->flags & BSF_SECTION_SYM) == 0 + && (symbol->flags & BSF_LOCAL) != 0) + { + *error_message = (char *) + _("32bits gp relative relocation occurs for an external symbol"); + return bfd_reloc_outofrange; + } + if (output_bfd != NULL) relocatable = TRUE; else diff --git a/bfd/elf64-mips.c b/bfd/elf64-mips.c index 699b862..e1051be 100644 --- a/bfd/elf64-mips.c +++ b/bfd/elf64-mips.c @@ -1586,8 +1586,7 @@ mips_elf64_gprel32_reloc (bfd *abfd, arelent *reloc_entry, asymbol *symbol, bfd_vma relocation; bfd_vma val; - /* If we're relocating, and this is an external symbol, we don't want - to change anything. */ + /* R_MIPS_GPREL32 relocations are defined for local symbols only. */ if (output_bfd != NULL && (symbol->flags & BSF_SECTION_SYM) == 0 && (symbol->flags & BSF_LOCAL) != 0) |