diff options
author | Tom de Vries <tdevries@suse.de> | 2025-09-20 14:48:56 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2025-09-20 14:48:56 +0200 |
commit | 6c054763f46352cb4a052599a61ff42044f7800f (patch) | |
tree | 129d2ff6a2adb408ebc7a0477739980d7e81282f | |
parent | 5322d99453a4e9128c98810bdaf6ed945a61699d (diff) | |
download | binutils-6c054763f46352cb4a052599a61ff42044f7800f.zip binutils-6c054763f46352cb4a052599a61ff42044f7800f.tar.gz binutils-6c054763f46352cb4a052599a61ff42044f7800f.tar.bz2 |
[gdb/testsuite, tclint] Fix gdb.reverse
Running tclint on the test-cases in gdb.reverse shows a few problems.
Fix these.
Tested on x86_64-linux.
37 files changed, 53 insertions, 54 deletions
diff --git a/gdb/tclint.toml b/gdb/tclint.toml index 4beb4dd..3b43523 100644 --- a/gdb/tclint.toml +++ b/gdb/tclint.toml @@ -28,7 +28,6 @@ exclude = [ "gdb/testsuite/gdb.fortran", "gdb/testsuite/gdb.mi", "gdb/testsuite/gdb.python", -"gdb/testsuite/gdb.reverse", "gdb/testsuite/gdb.threads", "gdb/testsuite/gdb.trace", # IGNORE (document reason in trailing comment): diff --git a/gdb/testsuite/gdb.reverse/aarch64-mops.exp b/gdb/testsuite/gdb.reverse/aarch64-mops.exp index 0f447a6..797a0c2 100644 --- a/gdb/testsuite/gdb.reverse/aarch64-mops.exp +++ b/gdb/testsuite/gdb.reverse/aarch64-mops.exp @@ -40,7 +40,7 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ return -1 } -if ![runto_main] { +if {![runto_main]} { return -1 } diff --git a/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp b/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp index 56ebb92..b5878f0 100644 --- a/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp +++ b/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp @@ -18,7 +18,7 @@ require supports_reverse set opts {} standard_testfile .S -if [info exists COMPILE] { +if {[info exists COMPILE]} { # make check RUNTESTFLAGS="gdb.reverse/amd64-tailcall-reverse.exp COMPILE=1" standard_testfile lappend opts debug optimize=-O2 @@ -30,11 +30,11 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } { return -1 } -if ![runto_main] { +if {![runto_main]} { return -1 } -if [supports_process_record] { +if {[supports_process_record]} { gdb_test_no_output "record" } diff --git a/gdb/testsuite/gdb.reverse/break-reverse.exp b/gdb/testsuite/gdb.reverse/break-reverse.exp index 02c38ac..6db7ce1 100644 --- a/gdb/testsuite/gdb.reverse/break-reverse.exp +++ b/gdb/testsuite/gdb.reverse/break-reverse.exp @@ -31,7 +31,7 @@ set end_location [gdb_get_line_number "end of main" ] runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/consecutive-reverse.exp b/gdb/testsuite/gdb.reverse/consecutive-reverse.exp index 8996d79..7434efb 100644 --- a/gdb/testsuite/gdb.reverse/consecutive-reverse.exp +++ b/gdb/testsuite/gdb.reverse/consecutive-reverse.exp @@ -26,7 +26,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/finish-precsave.exp b/gdb/testsuite/gdb.reverse/finish-precsave.exp index 596b40d..2e76a46 100644 --- a/gdb/testsuite/gdb.reverse/finish-precsave.exp +++ b/gdb/testsuite/gdb.reverse/finish-precsave.exp @@ -27,12 +27,12 @@ if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } -# Run until end, then save execution log. +# Run until end, then save execution log. set breakloc [gdb_get_line_number "end of main" "$srcfile"] gdb_test "break $breakloc" \ diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp index 1e92252..586d236 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp @@ -52,7 +52,7 @@ if {![runto_main]} { return 0 } -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-next.exp b/gdb/testsuite/gdb.reverse/finish-reverse-next.exp index f744e9c..07ba30c 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse-next.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse-next.exp @@ -41,7 +41,7 @@ # test only verified the reverse-finish command for a normal call that used # the LEP. -if ![supports_reverse] { +if {![supports_reverse]} { return } @@ -53,7 +53,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay. gdb_test_no_output "record" "turn on process record for test1" } diff --git a/gdb/testsuite/gdb.reverse/finish-reverse.exp b/gdb/testsuite/gdb.reverse/finish-reverse.exp index f90a79f..ff28bd8 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse.exp @@ -26,7 +26,7 @@ if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp index 76bd8a2..db2f5dc 100644 --- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp +++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp @@ -29,7 +29,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/getrandom.exp b/gdb/testsuite/gdb.reverse/getrandom.exp index 62640af..2756fa3 100644 --- a/gdb/testsuite/gdb.reverse/getrandom.exp +++ b/gdb/testsuite/gdb.reverse/getrandom.exp @@ -30,7 +30,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp index 5ff0f2b..37d070d 100644 --- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp @@ -29,7 +29,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp index fb04260..b3550e2 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp @@ -109,7 +109,7 @@ proc record_full_function {function} { gdb_breakpoint $end temporary gdb_continue_to_breakpoint "start ${function}_test" - if [supports_process_record] { + if {[supports_process_record]} { # Activate process record/replay. gdb_test_no_output "record" "${function}: turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/i386-reverse.exp b/gdb/testsuite/gdb.reverse/i386-reverse.exp index 8c22363..9aee9a4 100644 --- a/gdb/testsuite/gdb.reverse/i386-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-reverse.exp @@ -36,7 +36,7 @@ set end_of_inc_dec_tests [gdb_get_line_number " end inc_dec_tests "] runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp index 0c99480..aa4cfce 100644 --- a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp @@ -43,7 +43,7 @@ set end_sse4_test [gdb_get_line_number " end sse4_test "] runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp index 4b6a3f7..f3350fc 100644 --- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp @@ -36,7 +36,7 @@ set location [gdb_get_line_number "END I387-FLOAT-REVERSE"] gdb_test_no_output "record" "Turn on process record" # This can take awhile. set oldtimeout $timeout -set timeout [expr $oldtimeout + 120] +set timeout [expr {$oldtimeout + 120}] gdb_test "until $location" ".*$srcfile:$location.*" \ "record to end of main" set timeout $oldtimeout diff --git a/gdb/testsuite/gdb.reverse/insn-reverse.exp b/gdb/testsuite/gdb.reverse/insn-reverse.exp index 5b3a2cd..9e238f0 100644 --- a/gdb/testsuite/gdb.reverse/insn-reverse.exp +++ b/gdb/testsuite/gdb.reverse/insn-reverse.exp @@ -106,7 +106,7 @@ proc test { func testcase_nr } { } # Registers contents after each backward single step. - for {set i [expr $count - 1]} {$i >= 0} {incr i -1} { + for {set i [expr {$count - 1}]} {$i >= 0} {incr i -1} { gdb_test -nopass "reverse-stepi" set post_regs($i) [capture_command_output "info all-registers" ""] } diff --git a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp index 53b958d..94d9723 100644 --- a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp +++ b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# This file is part of the GDB testsuite. +# This file is part of the GDB testsuite. # This test tests the restoration of various kinds of machine state # to their original values with a process record log. We will execute # the program forward while it changes various types of data, and diff --git a/gdb/testsuite/gdb.reverse/machinestate.exp b/gdb/testsuite/gdb.reverse/machinestate.exp index 9177029..7edf517 100644 --- a/gdb/testsuite/gdb.reverse/machinestate.exp +++ b/gdb/testsuite/gdb.reverse/machinestate.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# This file is part of the GDB testsuite. +# This file is part of the GDB testsuite. # This test tests the restoration of various kinds of machine state # to their original values by reverse execution. We will execute # the program forward while it changes various types of data, and @@ -53,7 +53,7 @@ set endmain [gdb_get_line_number " end main " $srcfile] runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp index 6599345..151c117 100644 --- a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp +++ b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp @@ -23,7 +23,7 @@ # change is printed, since any instruction must have at least a change # to the PC. -if ![supports_reverse] { +if {![supports_reverse]} { return } @@ -52,7 +52,7 @@ if { ![runto_main] } { #confirm that GDB doesn't go crazy if recording isn't enabled test_print false "" "print before starting to record" -if ![supports_process_record] { +if {![supports_process_record]} { # No point in testing the rest if we can't record anything return } diff --git a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp index 454808d..574ab5e 100644 --- a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp +++ b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp @@ -52,7 +52,7 @@ if {![runto_main]} { return 0 } -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp index eb4f8eb..93ba3d1 100644 --- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp +++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp @@ -29,7 +29,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp index 47149f2..4456340 100644 --- a/gdb/testsuite/gdb.reverse/readv-reverse.exp +++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp @@ -29,7 +29,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/recursion.exp b/gdb/testsuite/gdb.reverse/recursion.exp index bfe1770..ca08930 100644 --- a/gdb/testsuite/gdb.reverse/recursion.exp +++ b/gdb/testsuite/gdb.reverse/recursion.exp @@ -26,7 +26,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp index 89cac87..af6f73f 100644 --- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp +++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp @@ -29,7 +29,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/s390-mvcle.exp b/gdb/testsuite/gdb.reverse/s390-mvcle.exp index 36cd611..642be8f 100644 --- a/gdb/testsuite/gdb.reverse/s390-mvcle.exp +++ b/gdb/testsuite/gdb.reverse/s390-mvcle.exp @@ -27,7 +27,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/sigall-precsave.exp b/gdb/testsuite/gdb.reverse/sigall-precsave.exp index 79838a0..552be4b 100644 --- a/gdb/testsuite/gdb.reverse/sigall-precsave.exp +++ b/gdb/testsuite/gdb.reverse/sigall-precsave.exp @@ -134,7 +134,7 @@ proc test_one_sig_reverse {prevsig} { } else { xfail "$testmsg (handled)" } - } + } } } @@ -142,12 +142,12 @@ clean_restart $::testfile runto gen_ABRT -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } -# Run until end, then save execution log. +# Run until end, then save execution log. set breakloc [gdb_get_line_number "end of main" "$srcfile"] gdb_test "break $breakloc" \ @@ -299,7 +299,7 @@ gdb_test "continue" \ "get signal TERM" gdb_test "continue" "Breakpoint.*handle_TERM.*" "send signal TERM" -gdb_test "continue" " end of main .*" "continue to sigall exit" +gdb_test "continue" " end of main .*" "continue to sigall exit" foreach sig [lreverse $signals] { test_one_sig_reverse $sig diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.exp b/gdb/testsuite/gdb.reverse/sigall-reverse.exp index 82547d8..f9259a1 100644 --- a/gdb/testsuite/gdb.reverse/sigall-reverse.exp +++ b/gdb/testsuite/gdb.reverse/sigall-reverse.exp @@ -140,7 +140,7 @@ proc test_one_sig_reverse {prevsig} { } else { xfail "$testmsg (handled)" } - } + } } } @@ -148,7 +148,7 @@ clean_restart $::testfile runto gen_ABRT -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp index 7c1cf0b..8b9cb20 100644 --- a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp +++ b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp @@ -18,7 +18,7 @@ require supports_reverse standard_testfile ".S" "${gdb_test_file_name}-nodebug.S" set executable ${testfile} -if [info exists COMPILE] { +if {[info exists COMPILE]} { # make check RUNTESTFLAGS="gdb.reverse/singlejmp-reverse.exp COMPILE=1" if { [build_executable_from_specs ${testfile}.exp $executable {} \ ${testfile}.c {debug optimize=-O2} \ @@ -36,11 +36,11 @@ if [info exists COMPILE] { clean_restart $executable -if ![runto_main] { +if {![runto_main]} { return -1 } -if [supports_process_record] { +if {[supports_process_record]} { gdb_test_no_output "record" } diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp index 9636167..0b93501 100644 --- a/gdb/testsuite/gdb.reverse/solib-precsave.exp +++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp @@ -52,7 +52,7 @@ if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable \ untested "failed to compile" return -1 } - + # Note: The test previously did "set debug-file-directory" to (try to) # ensure the debug info for the dynamic loader and libc weren't found. # This doesn't work if the debug info is in the .debug subdirectory. diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp index 4efd19f..8991177 100644 --- a/gdb/testsuite/gdb.reverse/solib-reverse.exp +++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp @@ -44,7 +44,7 @@ if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable $exec_opt untested "failed to compile" return -1 } - + # Note: The test previously did "set debug-file-directory" to (try to) # ensure the debug info for the dynamic loader and libc weren't found. # This doesn't work if the debug info is in the .debug subdirectory. @@ -58,7 +58,7 @@ gdb_load_shlib $library2 runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp index 9a0127a..d152454 100644 --- a/gdb/testsuite/gdb.reverse/step-precsave.exp +++ b/gdb/testsuite/gdb.reverse/step-precsave.exp @@ -229,7 +229,7 @@ gdb_test_multiple "stepi" "$test_message" { } } -re "ENTER CALLEE.*$gdb_prompt $" { - send_gdb "stepi\n" + send_gdb "stepi\n" exp_continue } -re "$pic_thunk_re.*$gdb_prompt $" { diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp index 6ecf1cd..78a11bf 100644 --- a/gdb/testsuite/gdb.reverse/step-reverse.exp +++ b/gdb/testsuite/gdb.reverse/step-reverse.exp @@ -30,7 +30,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } @@ -191,7 +191,7 @@ gdb_test_multiple "stepi" "$test_message" { } } -re "ENTER CALLEE.*$gdb_prompt $" { - send_gdb "stepi\n" + send_gdb "stepi\n" exp_continue } -re "$pic_thunk_re.*$gdb_prompt $" { diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/gdb.reverse/until-precsave.exp index 1f25a3a..325e4a8 100644 --- a/gdb/testsuite/gdb.reverse/until-precsave.exp +++ b/gdb/testsuite/gdb.reverse/until-precsave.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. */ -# This file is part of the GDB testsuite. It tests 'until' and +# This file is part of the GDB testsuite. It tests 'until' and # 'advance' in precord logfile. # This test suitable only for process record-replay @@ -147,7 +147,7 @@ gdb_test "advance $bp_location19" \ "factorial .value=720.*${srcfile}:$bp_location19.*" \ "reverse-advance to final return of factorial" -# Now do "until" across the recursive calls, +# Now do "until" across the recursive calls, # ending up in the same frame where we are now. gdb_test "until $bp_location7" \ diff --git a/gdb/testsuite/gdb.reverse/until-reverse.exp b/gdb/testsuite/gdb.reverse/until-reverse.exp index 240f6da..de138f5 100644 --- a/gdb/testsuite/gdb.reverse/until-reverse.exp +++ b/gdb/testsuite/gdb.reverse/until-reverse.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. */ -# This file is part of the GDB testsuite. It tests 'until' and +# This file is part of the GDB testsuite. It tests 'until' and # 'advance' in reverse debugging. require supports_reverse @@ -34,7 +34,7 @@ set bp_location21 [gdb_get_line_number "set breakpoint 21 here"] runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } @@ -120,7 +120,7 @@ gdb_test "advance $bp_location19" \ "factorial .value=720.*${srcfile}:$bp_location19.*" \ "reverse-advance to final return of factorial" -# Now do "until" across the recursive calls, +# Now do "until" across the recursive calls, # ending up in the same frame where we are now. gdb_test "until $bp_location7" \ diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp index c1cb402..26c3c99 100644 --- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp @@ -31,7 +31,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } diff --git a/gdb/testsuite/gdb.reverse/watch-reverse.exp b/gdb/testsuite/gdb.reverse/watch-reverse.exp index 6a694be..567ae4a 100644 --- a/gdb/testsuite/gdb.reverse/watch-reverse.exp +++ b/gdb/testsuite/gdb.reverse/watch-reverse.exp @@ -28,7 +28,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { runto_main -if [supports_process_record] { +if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" } |