diff options
| author | Tom Tromey <tromey@adacore.com> | 2025-09-04 09:33:07 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2025-09-04 14:39:32 -0600 |
| commit | 55fc9233a835a87d1a9020a8c71c473b03fc4f72 (patch) | |
| tree | f0b017a467214bf6e2a48fce314a023b78975a1a | |
| parent | e90c268b3e142bd97b10425fd32ea0d3ea1c8d07 (diff) | |
| download | binutils-55fc9233a835a87d1a9020a8c71c473b03fc4f72.zip binutils-55fc9233a835a87d1a9020a8c71c473b03fc4f72.tar.gz binutils-55fc9233a835a87d1a9020a8c71c473b03fc4f72.tar.bz2 | |
Don't require "Bss=" in qOffsets response
The "Bss=" part of the qOffsets response is documented as being
optional, but gdb in fact requires it. This patch fixes the bug.
I couldn't find a straightforward way to test this. gdbserver does
send 'Bss=' -- but this code is only enabled for a fairly specific
setup:
#if (defined(__UCLIBC__) \
&& defined(HAS_NOMMU) \
&& defined(PT_TEXT_ADDR) \
&& defined(PT_DATA_ADDR) \
&& defined(PT_TEXT_END_ADDR))
#define SUPPORTS_READ_OFFSETS
#endif
I also considered changing gdbserver to not send Bss=, but decided
against this, reasoning that we may as well not break compatibility
with older versions of gdb.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33319
Approved-By: Simon Marchi <simon.marchi@efficios.com>
| -rw-r--r-- | gdb/remote.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/gdb/remote.c b/gdb/remote.c index fb1e88a..1d8d9b1 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -4669,8 +4669,6 @@ remote_target::get_offsets () if (bss_addr != data_addr) warning (_("Target reported unsupported offsets: %s"), buf); } - else - lose = 1; } else if (startswith (ptr, "TextSeg=")) { |