aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-10-02 15:18:15 +0100
committerAndrew Burgess <aburgess@redhat.com>2022-10-19 12:15:08 +0100
commit536ff91bb8ea90c98737571f85827ce6770324c9 (patch)
treead710942bc16024b44c9f9fe5a7b09d0c06bedb4
parent6d6ae7c23dd59fe16f3e366e969b927d97fe5e01 (diff)
downloadbinutils-536ff91bb8ea90c98737571f85827ce6770324c9.zip
binutils-536ff91bb8ea90c98737571f85827ce6770324c9.tar.gz
binutils-536ff91bb8ea90c98737571f85827ce6770324c9.tar.bz2
gdb/testsuite: avoid creating files in gdb/testsuite directory
I spotted that the test gdb.dwarf2/dw2-using-debug-str.exp was creating an output file called debug_str_section in the root build/gdb/testsuite directory instead of using the build/gdb/testsuite/output/gdb.dwarf2/dw2-using-debug-str/ directory. This appears to be caused by a missing '$' character. We setup a variable debug_str_section which contains a path within the output directory, but then when we build the objcopy command we use 'debug_str_section' without a '$' prefix, as a result, we create the debug_str_section file. This commit adds the missing '$', the file is now created in the output directory.
-rw-r--r--gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
index d27554f..4d1c490 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
@@ -105,7 +105,7 @@ gdb_test "p global_var" " = \\{aa = 0, bb = 0, cc = 0\\}"
# cc-with-dwz-m.exp and cc-with-gnu-debuglink.exp. Handle this by
# skipping the remainder of the test-case.
set debug_str_section "${binfile}-debug-str"
-set args "--dump-section .debug_str=debug_str_section $binfile"
+set args "--dump-section .debug_str=${debug_str_section} $binfile"
set result [remote_exec host "[gdb_find_objcopy] $args"]
set status [lindex $result 0]
set output [lindex $result 1]