aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-07-01 00:51:20 -0600
committerTom Tromey <tom@tromey.com>2019-07-17 12:19:17 -0600
commit2cdfa11333867dbfcb2a6b631cda989d64f68944 (patch)
treece834c1475e64c9eaea6c26e41f1e563192f5f85
parent8e3cfd09e813fc1a2738b0d4d19d15358e438ace (diff)
downloadbinutils-2cdfa11333867dbfcb2a6b631cda989d64f68944.zip
binutils-2cdfa11333867dbfcb2a6b631cda989d64f68944.tar.gz
binutils-2cdfa11333867dbfcb2a6b631cda989d64f68944.tar.bz2
Change tui_get_register to return void
tui_get_register returns a tui_status, but nothing checks this, so it can return void instead. gdb/ChangeLog 2019-07-17 Tom Tromey <tom@tromey.com> * tui/tui-regs.c (tui_get_register): Return void.
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/tui/tui-regs.c13
2 files changed, 8 insertions, 9 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0de9c33..8de1558 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-07-17 Tom Tromey <tom@tromey.com>
+ * tui/tui-regs.c (tui_get_register): Return void.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
* tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
Simplify.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 382a441..52f6702 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -54,9 +54,9 @@ static void tui_show_register_group (tui_data_window *win_info,
struct frame_info *frame,
int refresh_values_only);
-static enum tui_status tui_get_register (struct frame_info *frame,
- struct tui_data_item_window *data,
- int regnum, bool *changedp);
+static void tui_get_register (struct frame_info *frame,
+ struct tui_data_item_window *data,
+ int regnum, bool *changedp);
@@ -646,13 +646,11 @@ tui_register_format (struct frame_info *frame, int regnum)
/* Get the register value from the given frame and format it for the
display. When changep is set, check if the new register value has
changed with respect to the previous call. */
-static enum tui_status
+static void
tui_get_register (struct frame_info *frame,
struct tui_data_item_window *data,
int regnum, bool *changedp)
{
- enum tui_status ret = TUI_FAILURE;
-
if (changedp)
*changedp = false;
if (target_has_registers)
@@ -666,8 +664,5 @@ tui_get_register (struct frame_info *frame,
*changedp = true;
xfree (prev_content);
-
- ret = TUI_SUCCESS;
}
- return ret;
}