aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2024-12-13 13:48:45 +1030
committerAlan Modra <amodra@gmail.com>2024-12-13 13:56:15 +1030
commit2cd1fe362711bb7221826cb5e1d791bffc04fc51 (patch)
tree684bf83987f3641154e80b393b582833eca4e1ed
parentd2cca35960319a7a0087ffda4beb679a23181df4 (diff)
downloadbinutils-2cd1fe362711bb7221826cb5e1d791bffc04fc51.zip
binutils-2cd1fe362711bb7221826cb5e1d791bffc04fc51.tar.gz
binutils-2cd1fe362711bb7221826cb5e1d791bffc04fc51.tar.bz2
small coffgen.c tidy
_bfd_coff_free_cached_info should always call _bfd_generic_bfd_free_cached_info, even if _bfd_coff_free_symbols returns an error. (It won't return an error here, but let's not leave anyone wondering about _bfd_coff_free_cached_info.) * coffgen.c (_bfd_coff_free_cached_info): Ignore return status of _bfd_coff_free_symbols.
-rw-r--r--bfd/coffgen.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index dc5b0f4..27bd54d 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -3295,8 +3295,7 @@ _bfd_coff_free_cached_info (bfd *abfd)
Do not clear the keep_syms and keep_strings flags.
These may have been set by pe_ILF_build_a_bfd() indicating
that the syms and strings pointers are not to be freed. */
- if (!_bfd_coff_free_symbols (abfd))
- return false;
+ _bfd_coff_free_symbols (abfd);
}
return _bfd_generic_bfd_free_cached_info (abfd);